From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen/makefile: Allow XEN_CHANGESET to be set externally Date: Fri, 17 May 2013 15:41:58 +0100 Message-ID: <519641B6.5030602@citrix.com> References: <396ebb07e2d0f6d737e8.1368796882@andrewcoop.uk.xensource.com> <20130517143233.GA18796@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130517143233.GA18796@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: "Keir (Xen.org)" , Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 17/05/2013 15:32, Olaf Hering wrote: > On Fri, May 17, Andrew Cooper wrote: > >> Build systems based on tarballs rather than source code trees, such as >> rpms/debs are unable to obtain changeset infomation. >> >> Allow XEN_CHANGESET to be optionally specified in the environment. > Isnt that already possible with 'echo "$XEN_CHANGESET" > .scmversion'? > > Olaf No - that results in the literal string "$XEN_CHANGESET" I have however identified a bug with the way in which xen/tools/scmversion deals with git. Patch on the way. ~Andrew