Re: [PATCH 2/3] Makefile: Fix some macro redefinition warnings

[Christopher Li <sparse@chrisli.org>]

On 05/16/2013 12:42 PM, Ramsay Jones wrote:
> 
> In particular, gcc complains as follows:
> 
>        CC       sparse-llvm.o
>   <command line>:1:1: warning: "__STDC_CONSTANT_MACROS" redefined
>   <command line>:1:1: warning: this is the location of the previous definition
>   <command line>:1:1: warning: "__STDC_FORMAT_MACROS" redefined
>   <command line>:1:1: warning: this is the location of the previous definition
>   <command line>:1:1: warning: "__STDC_LIMIT_MACROS" redefined
>   <command line>:1:1: warning: this is the location of the previous definition
> 
> The warnings are caused by the macros being defined twice on the
> gcc command line. These command line -D macro definitions come
> originally from the output of 'llvm-config --cflags', which is
> recorded in the $(LLVM_CFLAGS) variable. This variable is then
> included in the $(BASIC_CFLAGS) variable twice due to duplication
> of the target-specific additions to the BASIC_CFLAGS, viz:
> 
>   sparse-llvm_EXTRA_DEPS := sparse-llvm.o
>   sparse-llvm.o $(sparse-llvm_EXTRA_DEPS): BASIC_CFLAGS += $(LLVM_CFLAGS)
> 
> In order to suppress the warnings, we remove the duplication of
> the sparse-llvm.o target in the above rule.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>

I already commit a similar fix to remove the duplication.
I did not realize it can generate warning though.

Chris