From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ue4vw-0004SV-K1 for qemu-devel@nongnu.org; Sun, 19 May 2013 10:50:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ue4vv-0007Zf-1M for qemu-devel@nongnu.org; Sun, 19 May 2013 10:50:00 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:45100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ue4vu-0007YY-P9 for qemu-devel@nongnu.org; Sun, 19 May 2013 10:49:58 -0400 Message-ID: <5198E68A.7030805@msgid.tls.msk.ru> Date: Sun, 19 May 2013 18:49:46 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1368962825-553-1-git-send-email-aurelien@aurel32.net> In-Reply-To: <1368962825-553-1-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for 1.5] ide/macio: fix wrong opaque with TRIM support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Kevin Wolf , qemu-devel@nongnu.org, Christoph Hellwig 19.05.2013 15:27, Aurelien Jarno wrote: > Commit 215e47b9 enabled TRIM by default, which revealed a bug in TRIM > support for the IDE macio emulation driver, introduced in d353fb72. > > The call to dma_bdrv_io() is using a wrong opaque of type IDEState > instead of DBDMA_io. This patch fixes that. > > Fixes LP#1179104 > > Reported-by: Michael Tokarev > Cc: Kevin Wolf > Cc: Christoph Hellwig > Signed-off-by: Aurelien Jarno Tested-off-by: Michael Tokarev I can confirm with this patch the ppc testcase works again. Thanks! /mjt