From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com ([192.55.52.88]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Ue7Nq-0000fT-IE for bitbake-devel@lists.openembedded.org; Sun, 19 May 2013 19:27:31 +0200 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 19 May 2013 10:07:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,704,1363158000"; d="scan'208";a="340142810" Received: from unknown (HELO envy2.home) ([10.255.12.55]) by fmsmga002.fm.intel.com with ESMTP; 19 May 2013 10:07:25 -0700 Message-ID: <519906CE.4070904@intel.com> Date: Sun, 19 May 2013 10:07:26 -0700 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Richard Purdie References: <1368958915.32727.96.camel@ted> In-Reply-To: <1368958915.32727.96.camel@ted> X-Mailman-Approved-At: Mon, 20 May 2013 10:46:37 +0200 Cc: "Ashfield, Bruce" , Koen Kooi , bitbake-devel , Martin Jansa Subject: Re: [PATCH] fetch2: Shorten long srcrevs X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 May 2013 17:27:34 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/19/2013 03:21 AM, Richard Purdie wrote: > The long srcrevs are mainly used or the workdir construction as well as > the package version. The long entries are hashes generated by the git fetcher > and other scms using a similar revision mechanism. > > We need these to change when the package changes however collisions are > unlikely to happen within the domains we care about. The long revisions > have generated negative user feedback due to the use in path and file > names. > > This patch therefore truncates the revisions to 10 characters maximum. > > This should be safe in the contexts where these revisions are used as > the chances of spatially close collisions is very low (distant > collisions are not a major issue in the way we use these). > > Signed-off-by: Richard Purdie Thank you kindly, you beat me to it. Acked-by: Darren Hart > --- > CC'd various people who I believe might have feelings about this. The > patch depends on the sortable_revisions patch I just sent out. > > diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py > index f8f8244..402329d 100644 > --- a/bitbake/lib/bb/fetch2/__init__.py > +++ b/bitbake/lib/bb/fetch2/__init__.py > @@ -617,6 +617,8 @@ def get_srcrev(d): > > if len(scms) == 1 and len(urldata[scms[0]].names) == 1: > autoinc, rev = urldata[scms[0]].method.sortable_revision(scms[0], urldata[scms[0]], d, urldata[scms[0]].names[0]) > + if len(rev) > 10: > + rev = rev[:10] > if autoinc: > return "AUTOINC+" + rev > return rev > @@ -633,6 +635,8 @@ def get_srcrev(d): > ud = urldata[scm] > for name in ud.names: > autoinc, rev = ud.method.sortable_revision(scm, ud, d, name) > + if len(rev) > 10: > + rev = rev[:10] > if autoinc and not seenautoinc: > rev = "AUTOINC+" + rev > seenautoinc > > -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel