From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Ziyang Xuan <xuanziyang2@huawei.com>,
Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
Guoyang Zhou <zhouguoyang@huawei.com>,
Beilei Xing <beilei.xing@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Rosen Xu <rosen.xu@intel.com>,
Haiyue Wang <haiyue.wang@intel.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Jian Wang <jianwang@trustnetic.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org
Subject: Re: [PATCH] net: add macro for VLAN header length
Date: Wed, 17 Nov 2021 11:02:55 +0100 [thread overview]
Message-ID: <5199283.magWtXZHGd@thomas> (raw)
In-Reply-To: <bd227d1e-17de-4655-d143-59b36fbdf666@intel.com>
17/11/2021 11:00, Ferruh Yigit:
> On 11/16/2021 11:14 PM, Thomas Monjalon wrote:
> > 10/11/2021 18:40, Ferruh Yigit:
> >> Multiple drivers are defining macros for VLAN header length, to remove
> >> the redundancy defining macro in the ether header.
> >> And updated drivers to use the new macro.
> >>
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > [...]
> >> --- a/lib/net/rte_ether.h
> >> +++ b/lib/net/rte_ether.h
> >> +#define RTE_VLAN_HLEN 4
> >
> > Please could you add a doxygen comment for this constant?
> >
>
> ack.
>
> >> +/** Maximum VLAN frame length, including CRC. */
> >> #define RTE_ETHER_MAX_VLAN_FRAME_LEN \
> >> - (RTE_ETHER_MAX_LEN + 4)
> >> - /**< Maximum VLAN frame length, including CRC. */
> >> + (RTE_ETHER_MAX_LEN + RTE_VLAN_HLEN)
> >
> > What about QinQ?
> >
>
> I am just replacing hardcoded value with macro in this patch.
> Changing 'RTE_ETHER_MAX_LEN' may have unexpected affect, and
> may not be good thing to the at this stage.
Sure
But can we take this opportunity to note that this macro
does not take QinQ into account?
Just a comment update?
Same for RTE_VLAN_HLEN, it is only one VLAN.
next prev parent reply other threads:[~2021-11-17 10:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 17:40 [PATCH] net: add macro for VLAN header length Ferruh Yigit
2021-11-11 1:34 ` Wang, Haiyue
2021-11-12 2:36 ` Xu, Rosen
2021-11-12 6:09 ` Jiawen Wu
2021-11-16 23:14 ` Thomas Monjalon
2021-11-17 10:00 ` Ferruh Yigit
2021-11-17 10:02 ` Thomas Monjalon [this message]
2021-11-17 10:12 ` Ferruh Yigit
2021-11-17 18:08 ` [PATCH v2] " Ferruh Yigit
2021-11-17 18:24 ` [PATCH v3] " Ferruh Yigit
2021-11-17 18:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5199283.magWtXZHGd@thomas \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=chenbo.xia@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=jingjing.wu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=olivier.matz@6wind.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=shshaikh@marvell.com \
--cc=xiao.w.wang@intel.com \
--cc=xuanziyang2@huawei.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.