From: Jeff Kirsher <tarbal@gmail.com>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: jeffrey.t.kirsher@intel.com, e1000-devel@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split
Date: Mon, 20 May 2013 02:37:29 -0700 [thread overview]
Message-ID: <5199EED9.4040401@gmail.com> (raw)
In-Reply-To: <1369037707-27026-3-git-send-email-weiyang@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
On 05/20/2013 01:15 AM, Wei Yang wrote:
> In structure e1000_rx_desc_packet_split, the size of wb.upper.length is
> defined by a digit. This may introduce some problem when the lenght is
> changed.
>
> This patch use the marco PS_PAGE_BUFFERS for the definition. And move the
> definition to hw.h.
>
> Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
> ---
> drivers/net/ethernet/intel/e1000e/e1000.h | 3 ---
> drivers/net/ethernet/intel/e1000e/hw.h | 5 ++++-
> 2 files changed, 4 insertions(+), 4 deletions(-)
Thanks, I have added the patch to my queue for e1000e.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
next prev parent reply other threads:[~2013-05-20 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 8:15 [PATCH 0/4] trivial clean up for e1000e driver Wei Yang
2013-05-20 8:15 ` [PATCH 1/4] e1000e: Remove duplicate assignment of default rx/tx ring size Wei Yang
2013-05-20 9:37 ` Jeff Kirsher
2013-05-20 16:24 ` Wei Yang
2013-05-20 8:15 ` [PATCH 2/4] e1000e: Use marco instead of digit for defining e1000_rx_desc_packet_split Wei Yang
2013-05-20 9:37 ` Jeff Kirsher [this message]
2013-05-20 16:24 ` Wei Yang
2013-05-20 8:15 ` [PATCH 3/4] e1000e: Calculate the desc_len based on adapter type Wei Yang
2013-05-20 9:37 ` Jeff Kirsher
2013-05-20 16:25 ` Wei Yang
2013-08-22 10:57 ` Jeff Kirsher
2013-08-22 14:26 ` Wei Yang
2013-05-20 8:15 ` [PATCH 4/4] e1000e: Not initialize the e1000_ps_page array when packet-split is not used Wei Yang
2013-05-20 9:38 ` Jeff Kirsher
2013-05-20 16:25 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5199EED9.4040401@gmail.com \
--to=tarbal@gmail.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.