From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: Chris Rankin <rankincj@yahoo.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: 3.9.2 kernel - IR / em28xx_rc broken?
Date: Mon, 20 May 2013 14:40:47 +0200 [thread overview]
Message-ID: <519A19CF.5020605@googlemail.com> (raw)
In-Reply-To: <1369010702.23562.YahooMailNeo@web120304.mail.ne1.yahoo.com>
Am 20.05.2013 02:45, schrieb Chris Rankin:
> ----- Original Message -----
>
>> I'm not familar with ir-keytable and the RC core.
>> Mauro ? Can you take over ? ;)
> This patch seems to "do the right thing"... I doubt it will apply cleanly because of TAB/space issues, but you should get the idea :-).
>
> --- linux-3.9/drivers/media/usb/em28xx/em28xx-input.c.orig 2013-05-19 21:18:39.000000000 +0100
> +++ linux-3.9/drivers/media/usb/em28xx/em28xx-input.c 2013-05-20 01:36:51.000000000 +0100
> @@ -417,6 +417,7 @@
> *rc_type = RC_BIT_RC6_0;
> } else if (*rc_type & RC_BIT_UNKNOWN) {
> *rc_type = RC_BIT_UNKNOWN;
> + return 0;
> } else {
> *rc_type = ir->rc_type;
> return -EINVAL;
>
> This is against 3.9.3.
>
> Signed-off-by: Chris Rankin <rankincj@yahoo.com>
No, this patch is wrong.
Updating ir->rc_type with the new value of *rc_type is correct.
Regards,
Frank
next prev parent reply other threads:[~2013-05-20 12:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 13:57 3.9.2 kernel - IR / em28xx_rc broken? Chris Rankin
2013-05-18 14:36 ` Frank Schäfer
2013-05-18 15:17 ` Chris Rankin
2013-05-18 16:58 ` Frank Schäfer
2013-05-18 21:02 ` Chris Rankin
2013-05-19 13:40 ` Frank Schäfer
2013-05-19 14:11 ` Chris Rankin
2013-05-19 17:26 ` Frank Schäfer
2013-05-19 19:59 ` Chris Rankin
2013-05-19 21:02 ` Frank Schäfer
2013-05-19 22:36 ` Chris Rankin
2013-05-19 23:04 ` Chris Rankin
2013-05-20 12:38 ` Frank Schäfer
2013-05-20 12:47 ` Frank Schäfer
2013-05-20 13:01 ` Chris Rankin
2013-05-20 13:43 ` Frank Schäfer
2013-05-20 14:51 ` Chris Rankin
2013-05-20 15:36 ` Frank Schäfer
2013-05-20 16:02 ` Chris Rankin
2013-06-13 10:39 ` Mauro Carvalho Chehab
2013-06-13 10:50 ` Mauro Carvalho Chehab
2013-05-20 0:45 ` Chris Rankin
2013-05-20 12:40 ` Frank Schäfer [this message]
2013-05-20 12:48 ` Chris Rankin
2013-05-18 21:11 ` Chris Rankin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519A19CF.5020605@googlemail.com \
--to=fschaefer.oss@googlemail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=rankincj@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.