From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ee0-f51.google.com ([74.125.83.51]:53810 "EHLO mail-ee0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755331Ab3ETMjO (ORCPT ); Mon, 20 May 2013 08:39:14 -0400 Received: by mail-ee0-f51.google.com with SMTP id e51so3887622eek.10 for ; Mon, 20 May 2013 05:39:13 -0700 (PDT) Message-ID: <519A19CF.5020605@googlemail.com> Date: Mon, 20 May 2013 14:40:47 +0200 From: =?ISO-8859-1?Q?Frank_Sch=E4fer?= MIME-Version: 1.0 To: Chris Rankin CC: Mauro Carvalho Chehab , "linux-media@vger.kernel.org" Subject: Re: 3.9.2 kernel - IR / em28xx_rc broken? References: <1368885450.24433.YahooMailNeo@web120306.mail.ne1.yahoo.com> <519791E2.4080804@googlemail.com> <1368890230.26016.YahooMailNeo@web120301.mail.ne1.yahoo.com> <5197B34A.8010700@googlemail.com> <1368910949.59547.YahooMailNeo@web120304.mail.ne1.yahoo.com> <5198D669.6030007@googlemail.com> <1368972692.46197.YahooMailNeo@web120301.mail.ne1.yahoo.com> <51990B63.5090402@googlemail.com> <1368993591.43913.YahooMailNeo@web120305.mail.ne1.yahoo.com> <51993DDE.4070800@googlemail.com> <1369010702.23562.YahooMailNeo@web120304.mail.ne1.yahoo.com> In-Reply-To: <1369010702.23562.YahooMailNeo@web120304.mail.ne1.yahoo.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Am 20.05.2013 02:45, schrieb Chris Rankin: > ----- Original Message ----- > >> I'm not familar with ir-keytable and the RC core. >> Mauro ? Can you take over ? ;) > This patch seems to "do the right thing"... I doubt it will apply cleanly because of TAB/space issues, but you should get the idea :-). > > --- linux-3.9/drivers/media/usb/em28xx/em28xx-input.c.orig 2013-05-19 21:18:39.000000000 +0100 > +++ linux-3.9/drivers/media/usb/em28xx/em28xx-input.c 2013-05-20 01:36:51.000000000 +0100 > @@ -417,6 +417,7 @@ > *rc_type = RC_BIT_RC6_0; > } else if (*rc_type & RC_BIT_UNKNOWN) { > *rc_type = RC_BIT_UNKNOWN; > + return 0; > } else { > *rc_type = ir->rc_type; > return -EINVAL; > > This is against 3.9.3. > > Signed-off-by: Chris Rankin No, this patch is wrong. Updating ir->rc_type with the new value of *rc_type is correct. Regards, Frank