From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: Or Gerlitz <or.gerlitz@gmail.com>
Cc: Greg Rose <gregory.v.rose@intel.com>,
Yinghai Lu <yinghai@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Gu Zheng <guz.fnst@cn.fujitsu.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Duyck <alexander.h.duyck@intel.com>,
Yan Burman <yanb@mellanox.com>,
Sathya Perla <Sathya.Perla@emulex.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's
Date: Mon, 20 May 2013 15:58:37 +0300 [thread overview]
Message-ID: <519A1DFD.5080809@linux.intel.com> (raw)
In-Reply-To: <CAJZOPZ+L1QJdHePd_x9RAoqZKyJAKHo+hA8T1UZoe8=ozT98RA@mail.gmail.com>
On 20/05/2013 15:28, Or Gerlitz wrote:
> On Wed, May 15, 2013 at 7:12 PM, Greg Rose <gregory.v.rose@intel.com> wrote:
>
>
>> I'm really not a fan of this. Seems to me the tail is wagging the dog
>> here. Fix the driver to work without a PF driver being present.
>
> Greg, Alex,
>
> As I wrote over the V1 thread, currently we can't go and patch mlx4 to
> use the sysfs API nor defer the call from within our probe function to
> enable sriov since this requires some firmware change to allow
> enabling SRIOV after some resources are initialized/provisioned.
> Hence the patch suggested here or any other patch we can agree on
> which will make sure that VF probing is done only once the PF is ready
> is preferred, I think.
>
Maybe do the following:
1. split the VF PCI IDs into a separate PCI_ID device table.
2. have two pci_driver structs, one for all of the PF IDS and one with
the VF IDS.
3. only register the first pci_driver struct from mlx4_init().
4. register the one for the VFs once your PFs are all up and ready.
Eliezer
next prev parent reply other threads:[~2013-05-20 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 2:48 [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's Yinghai Lu
2013-05-15 4:39 ` Alexander Duyck
2013-05-15 16:12 ` Greg Rose
2013-05-20 12:28 ` Or Gerlitz
2013-05-20 12:58 ` Eliezer Tamir [this message]
2013-05-20 16:01 ` Yinghai Lu
2013-05-20 16:02 ` Ben Hutchings
2013-05-20 16:07 ` Ben Hutchings
2013-05-20 16:37 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519A1DFD.5080809@linux.intel.com \
--to=eliezer.tamir@linux.intel.com \
--cc=Sathya.Perla@emulex.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhelgaas@google.com \
--cc=gregory.v.rose@intel.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=yanb@mellanox.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.