From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX capable hardware" Date: Mon, 20 May 2013 11:13:29 -0700 Message-ID: <519A67C9.6000709@linux.intel.com> References: <20130514160108.GA5055@dhcp22.suse.cz> <1369062192-7066-1-git-send-email-mhocko@suse.cz> <519A483F.7070400@zytor.com> <20130520164335.GA9441@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:40143 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755457Ab3ETSNa (ORCPT ); Mon, 20 May 2013 14:13:30 -0400 In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Linus Torvalds Cc: Michal Hocko , "H. Peter Anvin" , =?UTF-8?B?RmVybmFuZG8gTHVpcyBWw6F6cXVleiBDYW8=?= , "Rafael J. Wysocki" , the arch/x86 maintainers , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List On 05/20/2013 10:21 AM, Linus Torvalds wrote: > On Mon, May 20, 2013 at 9:43 AM, Michal Hocko wrote: >> >> The configuration has been posted in the referenced thread: >> https://lkml.org/lkml/2013/5/14/398 > > Hmm. That's a regular intel i5 Sandybridge CPU. Which certainly has NX. > > Hmm. secondary_startup_64 isn't __initcode, is it? I think it's used > for resuming the other CPU's too and for CPU hotplug. Yes/no? > > If so early_pmd_flags shouldn't be __initdata, I think. > > Michal, does it work if you don't do the revert, but just remove the > __initdata instead? > Indeed. Looks like we corrupt a random bit in memory on resume. -hpa