Re: [PATCH] fetch2: Shorten long srcrevs

[Darren Hart <darren.hart@intel.com>]

On 05/20/2013 01:33 AM, Richard Purdie wrote:
> On Sun, 2013-05-19 at 14:32 +0200, Martin Jansa wrote:
>> On Sun, May 19, 2013 at 01:21:55PM +0300, Richard Purdie wrote:
>>> The long srcrevs are mainly used or the workdir construction as well as
>>> the package version. The long entries are hashes generated by the git fetcher
>>> and other scms using a similar revision mechanism.
>>>
>>> We need these to change when the package changes however collisions are
>>> unlikely to happen within the domains we care about. The long revisions
>>> have generated negative user feedback due to the use in path and file
>>> names.
>>>
>>> This patch therefore truncates the revisions to 10 characters maximum.
>>
>> What about 7 characters like git log --oneline is using?
> 
> git uses varying lengths depending on whether it detects collisions. I
> really don't want to have to do the collision detection or worry about
> this so 10 characters seemed like a nice number, its short enough to
> address the complaints but long enough to avoid problems.


Exactly. 10 seems like a good choice to me as well, it significantly
reduces the path length while keeping the implementation simple and
minimizing the chances of collisions.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel