From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"the arch/x86 maintainers" <x86@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX capable hardware"
Date: Mon, 20 May 2013 11:30:31 -0700 [thread overview]
Message-ID: <519A6BC7.7060902@linux.intel.com> (raw)
In-Reply-To: <20130520182306.GA5348@dhcp22.suse.cz>
On 05/20/2013 11:23 AM, Michal Hocko wrote:
> On Mon 20-05-13 10:21:09, Linus Torvalds wrote:
>> On Mon, May 20, 2013 at 9:43 AM, Michal Hocko <mhocko@suse.cz> wrote:
>>>
>>> The configuration has been posted in the referenced thread:
>>> https://lkml.org/lkml/2013/5/14/398
>>
>> Hmm. That's a regular intel i5 Sandybridge CPU. Which certainly has NX.
>>
>> Hmm. secondary_startup_64 isn't __initcode, is it? I think it's used
>> for resuming the other CPU's too and for CPU hotplug. Yes/no?
>>
>> If so early_pmd_flags shouldn't be __initdata, I think.
>>
>> Michal, does it work if you don't do the revert, but just remove the
>> __initdata instead?
>
> Right you are! The following patch on top of your tree fixes the
> problem. Thanks a lot. I will leave the proper changelog to somebody who
> is more familiar with the area but AFAIU the real problem is that
> early_pmd_flags is no longer available beacause the section is gone.
>
I'll write it up and send a pull request to Linus.
-hpa
next prev parent reply other threads:[~2013-05-20 18:30 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 16:01 3.10-rc1 system starts regular boot when waking from s2ram Michal Hocko
2013-05-14 20:09 ` Rafael J. Wysocki
2013-05-15 8:01 ` Michal Hocko
2013-05-15 8:29 ` Pavel Machek
2013-05-15 9:05 ` Pavel Machek
2013-05-15 9:56 ` Michal Hocko
2013-05-17 7:54 ` Michal Hocko
2013-05-17 12:11 ` Rafael J. Wysocki
2013-05-17 12:09 ` Michal Hocko
2013-05-17 12:23 ` Rafael J. Wysocki
2013-05-17 12:30 ` Michal Hocko
2013-05-15 13:17 ` CONFIG_HYPERVISOR_GUEST=y {-- replace -- CONFIG_PARAVIRT_GUEST=y {= { # CONFIG_HYPERVISOR_GUEST is not set } Re: 3.10-rc1 system starts regular boot when waking from s2ram Fw: [PATCH 2/2] x86: Make Linux guest support optional Victor Miasnikov
2013-05-15 13:17 ` Victor Miasnikov
2013-05-15 13:34 ` Michal Hocko
2013-05-15 13:44 ` Victor Miasnikov
2013-05-15 13:44 ` Victor Miasnikov
2013-05-15 13:46 ` Michal Hocko
2013-05-15 14:05 ` CONFIG_HYPERVISOR_GUEST=y {-- replace -- CONFIG_PARAVIRT_GUEST=y {= { # CONFIG_HYPERVISOR_GUEST is not set } Re: 3.10-rc1 " Victor Miasnikov
2013-05-15 14:05 ` Victor Miasnikov
2013-05-15 14:21 ` Borislav Petkov
2013-05-15 14:52 ` Victor Miasnikov
2013-05-15 14:52 ` Victor Miasnikov
2013-05-15 17:34 ` Luck, Tony
2013-05-15 17:34 ` Luck, Tony
2013-05-20 15:03 ` [PATCH] Revert "x86-64, init: Do not set NX bits on non-NX capable hardware" Michal Hocko
2013-05-20 15:58 ` H. Peter Anvin
2013-05-20 16:43 ` Michal Hocko
2013-05-20 17:21 ` Linus Torvalds
2013-05-20 18:13 ` H. Peter Anvin
2013-05-20 18:18 ` Linus Torvalds
2013-05-20 18:19 ` H. Peter Anvin
2013-05-20 18:23 ` Michal Hocko
2013-05-20 18:30 ` H. Peter Anvin [this message]
2013-05-20 18:31 ` Michal Hocko
2013-05-20 18:31 ` Linus Torvalds
2013-05-20 18:36 ` H. Peter Anvin
2013-05-20 18:42 ` [tip:x86/urgent] x86-64: Make early_pmd_flags __cpuinitdata tip-bot for H. Peter Anvin
2013-05-20 18:50 ` tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519A6BC7.7060902@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=fernando@oss.ntt.co.jp \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.