From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeX9a-0004ET-Th for qemu-devel@nongnu.org; Mon, 20 May 2013 16:58:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeX9W-0007eQ-7E for qemu-devel@nongnu.org; Mon, 20 May 2013 16:57:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59939 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeX9S-0007e5-Pl for qemu-devel@nongnu.org; Mon, 20 May 2013 16:57:54 -0400 Message-ID: <519A8E49.5090100@suse.de> Date: Mon, 20 May 2013 22:57:45 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1369070603-26778-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1369070603-26778-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 0/4] build: TARGET_ARCH/ARCH2/TYPE simplification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org Am 20.05.2013 19:23, schrieb Paolo Bonzini: > We have three variables currently in config-target.h: >=20 > - TARGET_ARCH is used to create a unique per-arch symbol, used in #ifde= fs. > It is also used as a string through config-target.h, but this is almo= st > always wrong. >=20 > - TARGET_ARCH2 is the name of the executable (minus the qemu-/qemu-syst= em- > prefix); it is not available in config-target.h. >=20 > - TARGET_TYPE is an enum but is otherwise the same as TARGET_ARCH2 Add to that - TARGET_BASE_ARCH in Makefile.target is assumed to be the name of the target-* subdirectory, but this will not always be desirable. > This series changes all uses of TARGET_ARCH to refer to TARGET_ARCH2 > instead (which is renamed to TARGET_NAME). The TARGET_ARCH #define > is dropped, only the per-arch symbol remains. TARGET_TYPE is then also > removed since it is serialized to the same string if TARGET_NAME is > used directly. For a long time already I have been carrying the following patch introducing TARGET_ARCH_DIR: https://github.com/afaerber/qemu-rl78/commit/9eddd60dae6603235fddf9070c73= e5bf65edf292 Still need to rebase that, but it looks as if there are no conflicts with your series. TARGET_NAME while a bit invasive is certainly nicer than TARGET_ARCH2, and dropping TargetType enum makes rebasing/adding new targets easier. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg