From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeXpO-0008LC-I5 for qemu-devel@nongnu.org; Mon, 20 May 2013 17:41:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UeXpJ-00043T-QM for qemu-devel@nongnu.org; Mon, 20 May 2013 17:41:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UeXpJ-00043G-IT for qemu-devel@nongnu.org; Mon, 20 May 2013 17:41:05 -0400 Message-ID: <519A986D.7020504@redhat.com> Date: Mon, 20 May 2013 15:41:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1369070603-26778-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1369070603-26778-1-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2NWXTXRPBEULUAFTJITXL" Subject: Re: [Qemu-devel] [RFC PATCH 0/4] build: TARGET_ARCH/ARCH2/TYPE simplification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2NWXTXRPBEULUAFTJITXL Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/20/2013 11:23 AM, Paolo Bonzini wrote: > We have three variables currently in config-target.h: >=20 > - TARGET_ARCH is used to create a unique per-arch symbol, used in #ifde= fs. > It is also used as a string through config-target.h, but this is almo= st > always wrong. >=20 > - TARGET_ARCH2 is the name of the executable (minus the qemu-/qemu-syst= em- > prefix); it is not available in config-target.h. >=20 > - TARGET_TYPE is an enum but is otherwise the same as TARGET_ARCH2 >=20 > This series changes all uses of TARGET_ARCH to refer to TARGET_ARCH2 > instead (which is renamed to TARGET_NAME). The TARGET_ARCH #define > is dropped, only the per-arch symbol remains. TARGET_TYPE is then also= > removed since it is serialized to the same string if TARGET_NAME is > used directly. [Ugg - there's no good way to convince Thunderbird to reply to just 4/4, when you inline everything after your "-- " signoff...] > +++ b/qapi-schema.json > @@ -3008,22 +3008,6 @@ > { 'command': 'query-fdsets', 'returns': ['FdsetInfo'] } > =20 > ## > -# @TargetType > -# > -# Target CPU emulation type > -# > -# These parameters correspond to the softmmu binary CPU name that is c= urrently > -# running. > -# > -# Since: 1.2.0 > -## > -{ 'enum': 'TargetType', > - 'data': [ 'alpha', 'arm', 'cris', 'i386', 'lm32', 'm68k', 'microblaz= eel', > - 'microblaze', 'mips64el', 'mips64', 'mipsel', 'mips', 'mox= ie', > - 'or32', 'ppc64', 'ppcemb', 'ppc', 's390x', 'sh4eb', 'sh4',= > - 'sparc64', 'sparc', 'unicore32', 'x86_64', 'xtensaeb', 'xt= ensa' ] } > - > -## > # @TargetInfo: > # > # Information describing the QEMU target. > @@ -3033,7 +3017,7 @@ > # Since: 1.2.0 > ## > { 'type': 'TargetInfo', > - 'data': { 'arch': 'TargetType' } } > + 'data': { 'arch': 'str' } } No change to the wire format, and being type-safe didn't really add anything (since a binary only supported a single arch, not the entire enum of arches). Chaning now will avoid us being locked into something once introspection is added (deleting it after we have introspection may still be possible, but it would be harder to prove that it is not backwards incompatible at that point). I'm okay with this deletion. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2NWXTXRPBEULUAFTJITXL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRmphtAAoJEKeha0olJ0Nqw6QH/2XHjd3LnNPp5004eBhSAshD wDoPjnKxD1ngSFvZV3VKJDey9obHRKXW8AaS4WnDa7FcxJadeW7gHEccpOVdfAWj jOM3/fspFTuWAQgkjo2Cv+JHFVEQxk4dFv8mGOPSCo9JBTst0wW8uA9YJzhjJEQF swMuAwGmB9+oKiBqmxGEAn47KBiV5T8OMGFUMZZ5PktGAa+riURJlx8WIPLdW0tJ lfAoM02+RlX46YYbstgUMim2JgHD0ggOBIoqGGZebAvx09THwvV6zERr44CC4nvr uxpDHhmx8x/jbxOv4FIgKIyeAP4xxvwHgedEo422ihC2dwMUu38O65aTD0uS4vU= =LHyC -----END PGP SIGNATURE----- ------enig2NWXTXRPBEULUAFTJITXL--