From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 0/4] build: TARGET_ARCH/ARCH2/TYPE simplification
Date: Mon, 20 May 2013 23:45:54 +0200 [thread overview]
Message-ID: <519A9992.6090000@suse.de> (raw)
In-Reply-To: <CAFEAcA9_p39k6so_TDU5UbSTo0v+bjJ0ssm8GedmGf98UazBLw@mail.gmail.com>
Am 20.05.2013 23:33, schrieb Peter Maydell:
> On 20 May 2013 21:57, Andreas Färber <afaerber@suse.de> wrote:
>> Am 20.05.2013 19:23, schrieb Paolo Bonzini:
>> Add to that
>>
>> - TARGET_BASE_ARCH in Makefile.target is assumed to be the name of the
>> target-* subdirectory, but this will not always be desirable.
>
> Isn't it the name of the target-* subdirectory by definition?
> (ie we need to be able to set that somehow if you have a subarch
> that's piggybacking on another subarch, and this is how we set it).
The base architecture is by definition the architecture another one is
basing on. The base architecture's define is present for all derived
ones (e.g., TARGET_PPC for TARGET_PPC64).
>> For a long time already I have been carrying the following patch
>> introducing TARGET_ARCH_DIR:
>> https://github.com/afaerber/qemu-rl78/commit/9eddd60dae6603235fddf9070c73e5bf65edf292
>>
>> Still need to rebase that, but it looks as if there are no conflicts
>> with your series.
>
> It seems to me that if you're going to put the source code in
> the target-rl78 directory you should make rl78 the
> TARGET_BASE_ARCH. Alternatively call the directory target-78k0
> if you want the TARGET_BASE_ARCH to be 78k0.
I tried that and it is awful for two reasons:
* 78k0 is not a valid identifier in C, so I can't write 78k0_cpu_foo.
* I only care about implementing RL78 but I know it has a documented
base architecture of 78K/0 that I would like to mark up to avoid the
issues we have with implementing older ARM versions after the fact. Ties
in with the topic of whether to autogenerate the default targets.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-05-20 21:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 17:23 [Qemu-devel] [RFC PATCH 0/4] build: TARGET_ARCH/ARCH2/TYPE simplification Paolo Bonzini
2013-05-20 20:57 ` Andreas Färber
2013-05-20 21:33 ` Peter Maydell
2013-05-20 21:45 ` Andreas Färber [this message]
2013-05-20 22:50 ` Peter Maydell
2013-05-20 21:41 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519A9992.6090000@suse.de \
--to=afaerber@suse.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.