All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Dave Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Don Skidmore <donanld.c.skidmore@intel.com>,
	e1000-devel@lists.sourceforge.net,
	Willem de Bruijn <willemb@google.com>, HPA <hpa@zytor.com>,
	Eliezer Tamir <eliezer@tamir.org.il>
Subject: Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling
Date: Tue, 21 May 2013 09:16:28 +0300	[thread overview]
Message-ID: <519B113C.6070006@linux.intel.com> (raw)
In-Reply-To: <20130520162227.GD24555@two.firstfloor.org>

On 20/05/2013 19:22, Andi Kleen wrote:
>> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
>> index f98ca63..cfcf0ea 100644
>> --- a/Documentation/networking/ip-sysctl.txt
>> +++ b/Documentation/networking/ip-sysctl.txt
>> @@ -19,6 +19,11 @@ ip_no_pmtu_disc - BOOLEAN
>>   	Disable Path MTU Discovery.
>>   	default FALSE
>>
>> +ip_low_latency_poll - INTEGER
>> +	Low latency busy poll timeout. (needs CONFIG_INET_LL_RX_POLL)
>> +	Approximate time in ms to spin waiting for packets on the device queue.
>> +	default 0
>
> Can you document the suggested value here?

ok
> Also I would add something like "may increase power usage"

:)
> The other thing I would add is a linuxmib statistic counter so that
> we can see the polling happens.

Yes,
I will add a counter for packets that were received through this path.

Eliezer

WARNING: multiple messages have this Message-ID (diff)
From: Eliezer Tamir <eliezer.tamir@linux.intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Willem de Bruijn <willemb@google.com>,
	e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	linux-kernel@vger.kernel.org,
	Don Skidmore <donanld.c.skidmore@intel.com>, HPA <hpa@zytor.com>,
	Eliezer Tamir <eliezer@tamir.org.il>,
	Dave Miller <davem@davemloft.net>
Subject: Re: [PATCH v2 net-next 1/4] net: implement support for low latency socket polling
Date: Tue, 21 May 2013 09:16:28 +0300	[thread overview]
Message-ID: <519B113C.6070006@linux.intel.com> (raw)
In-Reply-To: <20130520162227.GD24555@two.firstfloor.org>

On 20/05/2013 19:22, Andi Kleen wrote:
>> diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt
>> index f98ca63..cfcf0ea 100644
>> --- a/Documentation/networking/ip-sysctl.txt
>> +++ b/Documentation/networking/ip-sysctl.txt
>> @@ -19,6 +19,11 @@ ip_no_pmtu_disc - BOOLEAN
>>   	Disable Path MTU Discovery.
>>   	default FALSE
>>
>> +ip_low_latency_poll - INTEGER
>> +	Low latency busy poll timeout. (needs CONFIG_INET_LL_RX_POLL)
>> +	Approximate time in ms to spin waiting for packets on the device queue.
>> +	default 0
>
> Can you document the suggested value here?

ok
> Also I would add something like "may increase power usage"

:)
> The other thing I would add is a linuxmib statistic counter so that
> we can see the polling happens.

Yes,
I will add a counter for packets that were received through this path.

Eliezer

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired

  reply	other threads:[~2013-05-21  6:16 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-19 10:25 [PATCH v2 net-next 0/4] net: low latency Ethernet device polling Eliezer Tamir
2013-05-19 10:25 ` [PATCH v2 net-next 1/4] net: implement support for low latency socket polling Eliezer Tamir
2013-05-19 10:25   ` Eliezer Tamir
2013-05-20  7:54   ` David Miller
2013-05-20  8:29     ` Joe Perches
2013-05-20  8:29       ` Joe Perches
2013-05-20  9:16       ` David Miller
2013-05-20  9:39     ` Eliezer Tamir
2013-05-20  9:39       ` Eliezer Tamir
2013-05-20 19:34       ` David Miller
2013-05-20 16:22   ` Andi Kleen
2013-05-20 16:22     ` Andi Kleen
2013-05-21  6:16     ` Eliezer Tamir [this message]
2013-05-21  6:16       ` Eliezer Tamir
2013-05-19 10:25 ` [PATCH v2 net-next 2/4] tcp: add TCP support for low latency receive poll Eliezer Tamir
2013-05-19 10:25   ` Eliezer Tamir
2013-05-19 10:25 ` [PATCH v2 net-next 3/4] ixgbe: Add support for ndo_ll_poll Eliezer Tamir
2013-05-19 10:25   ` Eliezer Tamir
2013-05-19 10:26 ` [PATCH v2 net-next 4/4] ixgbe: add extra stats " Eliezer Tamir
2013-05-19 19:06 ` [PATCH v2 net-next 0/4] net: low latency Ethernet device polling Or Gerlitz
2013-05-19 19:06   ` Or Gerlitz
2013-05-19 19:20   ` Eliezer Tamir
2013-05-19 19:20     ` Eliezer Tamir
2013-05-20 20:09     ` [E1000-devel] " Jeff Kirsher
2013-05-20 22:08       ` Jesse Brandeburg
2013-05-19 19:25   ` Eliezer Tamir
2013-05-19 19:56     ` Or Gerlitz
2013-05-20 10:26       ` Eliezer Tamir
2013-05-20 22:44   ` Brandeburg, Jesse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519B113C.6070006@linux.intel.com \
    --to=eliezer.tamir@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=donanld.c.skidmore@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=eliezer@tamir.org.il \
    --cc=hpa@zytor.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.