Re: [PATCH 05/11] arm: mvebu: convert Armada 370/XP to common init

[Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>]

On 05/21/2013 08:28 AM, Sascha Hauer wrote:
> Sebastian,
>
>> +static int armada_370_xp_init_soc(void)
>>   {
>>   	unsigned long phys_base, phys_size;
>>
>> -	mvebu_init_clocks();
>> +	armada_370_xp_init_clocks();
>>   	add_generic_device("mvebu-timer", DEVICE_ID_SINGLE, NULL,
>> -			   MVEBU_TIMER_BASE, 0x30, IORESOURCE_MEM,
>> -			   NULL);
>> -	mvebu_memory_find(&phys_base,&phys_size);
>> +			   (unsigned int)ARMADA_370_XP_TIMER_BASE, 0x30,
>> +			   IORESOURCE_MEM, NULL);
>> +	armada_370_xp_memory_find(&phys_base,&phys_size);
>>   	arm_add_mem_device("ram0", phys_base, phys_size);
>> +	armada_370_xp_add_uart();
>
> How do you want to support a board which uses another UART instead of
> uart0 when you call this from SoC code?
>
> I don't think this line should be here.

Sascha,

there is a CONFIG_MVEBU_CONSOLE_UART introduced in patch 3. You can
select the debug console which defaults to 0 for all SoCs.

It is converted to the console uart above:

+#define CONSOLE_UART_BASE	\
+	ARMADA_370_XP_UARTn_BASE(CONFIG_MVEBU_CONSOLE_UART)

Sebastian

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox