From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Sylvain Munaut <s.munaut@whatever-company.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATH] tools/hotplug/Linux: Add IPv6 support to vif-common filtering
Date: Tue, 21 May 2013 13:26:42 +0100 [thread overview]
Message-ID: <519B6802.6050909@eu.citrix.com> (raw)
In-Reply-To: <1369066330.21246.17.camel@zakaz.uk.xensource.com>
On 05/20/2013 05:12 PM, Ian Campbell wrote:
> On Mon, 2013-05-13 at 14:55 +0100, Sylvain Munaut wrote:
>> The vif-common.sh hotplug script doesn't support ipv6 iptables
>> filtering setup. The attached patch adds basic filtering capability so
>> that if an IPv6 is specified, it's added to the 'authorized' source
>> list.
>> Basically the same behavior as for ipv4.
>>
>> I've been using this patch for some time on xen 4.1 and I've just
>> forward ported it to xen master (it applied cleanly and didn't see any
>> changes that would matter).
>
> Thanks, this looks plausible, at least as far as I am able to tell. Is
> there anyone around who could review this from the ipv6/iptables PoV?
>
> WRT the release, we are now frozen for 4.3 and I'd be concerned about
> introducing a subtle (or not so subtle) networking regression. George
> what do you think?
Yeah, I think given that no one has been clamoring for it, it would be
better to wait until 4.4.
-George
prev parent reply other threads:[~2013-05-21 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 13:55 [PATH] tools/hotplug/Linux: Add IPv6 support to vif-common filtering Sylvain Munaut
2013-05-20 16:12 ` Ian Campbell
2013-05-21 8:57 ` Sylvain Munaut
2013-05-21 12:26 ` George Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B6802.6050909@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=s.munaut@whatever-company.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.