From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCHv4 05/39] memcg, thp: charge huge cache pages Date: Tue, 21 May 2013 12:04:54 -0700 Message-ID: <519BC556.1050908@sr71.net> References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-6-git-send-email-kirill.shutemov@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko , KAMEZAWA Hiroyuki To: "Kirill A. Shutemov" Return-path: In-Reply-To: <1368321816-17719-6-git-send-email-kirill.shutemov@linux.intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > mem_cgroup_cache_charge() has check for PageCompound(). The check > prevents charging huge cache pages. > > I don't see a reason why the check is present. Looks like it's just > legacy (introduced in 52d4b9a memcg: allocate all page_cgroup at boot). FWIW, that commit introduced two PageCompound() checks. The other one went away inexplicably in 01b1ae63c22. Acked-by: Dave Hansen -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755473Ab3EUTE6 (ORCPT ); Tue, 21 May 2013 15:04:58 -0400 Received: from www.sr71.net ([198.145.64.142]:44239 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751764Ab3EUTE5 (ORCPT ); Tue, 21 May 2013 15:04:57 -0400 Message-ID: <519BC556.1050908@sr71.net> Date: Tue, 21 May 2013 12:04:54 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko , KAMEZAWA Hiroyuki Subject: Re: [PATCHv4 05/39] memcg, thp: charge huge cache pages References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-6-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1368321816-17719-6-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > mem_cgroup_cache_charge() has check for PageCompound(). The check > prevents charging huge cache pages. > > I don't see a reason why the check is present. Looks like it's just > legacy (introduced in 52d4b9a memcg: allocate all page_cgroup at boot). FWIW, that commit introduced two PageCompound() checks. The other one went away inexplicably in 01b1ae63c22. Acked-by: Dave Hansen