From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCHv4 27/39] x86-64, mm: proper alignment mappings with hugepages Date: Tue, 21 May 2013 16:20:13 -0700 Message-ID: <519C012D.7070006@sr71.net> References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-28-git-send-email-kirill.shutemov@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: "Kirill A. Shutemov" Return-path: In-Reply-To: <1368321816-17719-28-git-send-email-kirill.shutemov@linux.intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > Make arch_get_unmapped_area() return unmapped area aligned to HPAGE_MASK > if the file mapping can have huge pages. OK, so there are at least four phases of this patch set which are distinct to me. 1. Prep work that can go upstream now 2. Making the page cache able to hold compound pages 3. Making thp-cache work with ramfs 4. Making mmap() work with thp-cache (1) needs to go upstream now. (2) and (3) are related and should go upstream together. There should be enough performance benefits from this alone to let them get merged. (4) has lot of the code complexity, and is certainly required... eventually. I think you should stop for the _moment_ posting things in this category and wait until you get the other stuff merged. Go ahead and keep it in your git tree for toying around with, but don't try to get it merged until parts 1-3 are in. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753432Ab3EUXUS (ORCPT ); Tue, 21 May 2013 19:20:18 -0400 Received: from www.sr71.net ([198.145.64.142]:46218 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696Ab3EUXUQ (ORCPT ); Tue, 21 May 2013 19:20:16 -0400 Message-ID: <519C012D.7070006@sr71.net> Date: Tue, 21 May 2013 16:20:13 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 27/39] x86-64, mm: proper alignment mappings with hugepages References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-28-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1368321816-17719-28-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" > > Make arch_get_unmapped_area() return unmapped area aligned to HPAGE_MASK > if the file mapping can have huge pages. OK, so there are at least four phases of this patch set which are distinct to me. 1. Prep work that can go upstream now 2. Making the page cache able to hold compound pages 3. Making thp-cache work with ramfs 4. Making mmap() work with thp-cache (1) needs to go upstream now. (2) and (3) are related and should go upstream together. There should be enough performance benefits from this alone to let them get merged. (4) has lot of the code complexity, and is certainly required... eventually. I think you should stop for the _moment_ posting things in this category and wait until you get the other stuff merged. Go ahead and keep it in your git tree for toying around with, but don't try to get it merged until parts 1-3 are in.