From: "Nithin Nayak Sujir" <nsujir@broadcom.com>
To: "Peter Huewe" <peterhuewe@gmx.de>
Cc: "David S. Miller" <davem@davemloft.net>,
"Michael Chan" <mchan@broadcom.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/19] net/ethernet/broadcom/tg3: Use module_pci_driver to register driver
Date: Tue, 21 May 2013 17:22:48 -0700 [thread overview]
Message-ID: <519C0FD8.80705@broadcom.com> (raw)
In-Reply-To: <1369177096-19674-11-git-send-email-peterhuewe@gmx.de>
On 05/21/2013 03:58 PM, Peter Huewe wrote:
> Removing some boilerplate by using module_pci_driver instead of calling
> register and unregister in the otherwise empty init/exit functions.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> drivers/net/ethernet/broadcom/tg3.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index fb06aa1..4f0e3fe 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -17804,15 +17804,4 @@ static struct pci_driver tg3_driver = {
> .driver.pm = &tg3_pm_ops,
> };
>
> -static int __init tg3_init(void)
> -{
> - return pci_register_driver(&tg3_driver);
> -}
> -
> -static void __exit tg3_cleanup(void)
> -{
> - pci_unregister_driver(&tg3_driver);
> -}
> -
> -module_init(tg3_init);
> -module_exit(tg3_cleanup);
> +module_pci_driver(tg3_driver);
>
Acked-by: Nithin Nayak Sujir <nsujir@broadcom.com>
next prev parent reply other threads:[~2013-05-22 0:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 22:42 [PATCH 01/19] net/ethernet/silan/sc92031: Use module_pci_driver to register driver Peter Huewe
2013-05-21 22:42 ` [PATCH 02/19] net/ethernet/atheros/atl1c/atl1c_main: " Peter Huewe
2013-05-21 22:42 ` [PATCH 03/19] net/ethernet/atheros/atl1e/atl1e_main: " Peter Huewe
2013-05-22 0:19 ` Hannes Frederic Sowa
2013-05-21 22:42 ` [PATCH 04/19] net/ethernet/atheros/atlx/atl1: " Peter Huewe
2013-05-21 22:42 ` [PATCH 05/19] net/ethernet/sis/sis190: " Peter Huewe
2013-05-21 22:42 ` [PATCH 06/19] net/ethernet/dec/tulip/xircom_cb: " Peter Huewe
2013-05-22 0:41 ` Grant Grundler
2013-05-21 22:42 ` [PATCH 07/19] net/ethernet/toshiba/tc35815: " Peter Huewe
2013-05-21 22:42 ` [PATCH 08/19] net/ethernet/icplus/ipg: " Peter Huewe
2013-05-21 22:42 ` [PATCH 09/19] net/ethernet/alteon/acenic: " Peter Huewe
2013-05-21 22:58 ` [PATCH 10/19] net/ethernet/broadcom/bnx2: " Peter Huewe
2013-05-21 22:58 ` [PATCH 11/19] net/ethernet/broadcom/tg3: " Peter Huewe
2013-05-22 0:22 ` Nithin Nayak Sujir [this message]
2013-05-21 22:58 ` [PATCH 12/19] net/ethernet/sgi/ioc3-eth: " Peter Huewe
2013-05-21 22:58 ` Peter Huewe
2013-05-22 7:53 ` Ralf Baechle
2013-05-21 22:58 ` [PATCH 13/19] net/ethernet/qlogic/qlge/qlge_main: " Peter Huewe
2013-05-21 22:58 ` [PATCH 14/19] net/ethernet/sun/sungem: " Peter Huewe
2013-05-21 22:58 ` [PATCH 15/19] net/ethernet/amd/amd8111e: " Peter Huewe
2013-05-21 23:42 ` [PATCH 16/19] net/hippi/rrunner: " Peter Huewe
2013-05-21 23:42 ` [PATCH 17/19] net/fddi/skfp/skfddi: " Peter Huewe
2013-05-21 23:42 ` [PATCH 18/19] net/ethernet/chelsio/cxgb/cxgb2: " Peter Huewe
2013-05-21 23:42 ` [PATCH 19/19] net/ethernet/nvidia/forcedeth: " Peter Huewe
2013-05-22 21:44 ` [PATCH 01/19] net/ethernet/silan/sc92031: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519C0FD8.80705@broadcom.com \
--to=nsujir@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.