From: Saul Wold <sgw@linux.intel.com>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] patch: diable xattr as default
Date: Tue, 21 May 2013 17:43:22 -0700 [thread overview]
Message-ID: <519C14AA.2040604@linux.intel.com> (raw)
In-Reply-To: <519C1005.6000205@windriver.com>
On 05/21/2013 05:23 PM, Mark Hatle wrote:
> On 5/21/13 7:20 PM, Mark Hatle wrote:
>> On 5/21/13 6:54 PM, Saul Wold wrote:
>>> There is a optional dependency on xattr (and thus the attr package),
>>> disable it by default, to ensure it builds correctly.
>>>
>>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>>> ---
>>> meta/recipes-devtools/patch/patch_2.7.1.bb | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/recipes-devtools/patch/patch_2.7.1.bb
>>> b/meta/recipes-devtools/patch/patch_2.7.1.bb
>>> index 38df034..b131204 100644
>>> --- a/meta/recipes-devtools/patch/patch_2.7.1.bb
>>> +++ b/meta/recipes-devtools/patch/patch_2.7.1.bb
>>> @@ -9,3 +9,5 @@ SRC_URI[sha256sum] =
>>> "c05f28668c3474bc63adcd48abae921d15e71c254fbebdbaeda40456d6
>>> LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
>>>
>>> acpaths = "-I ${S}/m4 "
>>> +
>>> +EXTRA_OECONF += "--disable-xattr"
>>
>> There is an xattr distro feature. It would be better to use:
>>
>> ENABLE_XATTR = "${@base_contains('DISTRO_FEATURES', 'xattr',
>> '--enable-xattr',
>> '--disable-xattr', d)}"
>>
>> EXTRA_OECONF += "${ENABLE_XATTR}"
>>
>> (Might need a -native/-nativesdk version?)
>
> I forgot, PACKAGECONFIG might be better to use.... then the attr
> package dependencies can more easily be added.
>
> PACKAGECONFIG ?= "${@base_contains('DISTRO_FEATURES', 'xattr', 'xattr',
> '', d)}"
> PACKAGECONFIG[xattr] = "--enable-xattr,--disable-xattr,attr,"
>
Yup, this is more correct and slap my hand for forgetting the xattr
DISTO_FEATURE!
V2 coming after some tests.
Sau!
> --Mark
>
>>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
prev parent reply other threads:[~2013-05-22 0:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 23:54 [PATCH] patch: diable xattr as default Saul Wold
2013-05-22 0:20 ` Mark Hatle
2013-05-22 0:23 ` Mark Hatle
2013-05-22 0:43 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519C14AA.2040604@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.