All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miao Xie <miaox@cn.fujitsu.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: chris.mason@fusionio.com, yongjun_wei@trendmicro.com.cn,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH -next] Btrfs: return error code in btrfs_check_trunc_cache_free_space()
Date: Wed, 22 May 2013 09:35:51 +0800	[thread overview]
Message-ID: <519C20F7.1090709@cn.fujitsu.com> (raw)
In-Reply-To: <CAPgLHd99KGnuvOqOzKHveWLg1huNK1b9=PbC331nKrGXrGF54w@mail.gmail.com>

On Tue, 21 May 2013 10:39:21 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fix to return error code instead always return 0 from function
> btrfs_check_trunc_cache_free_space().
> Introduced by commit 7b61cd92242542944fc27024900c495a6a7b3396
> (Btrfs: don't use global block reservation for inode cache truncation)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Thanks for your fix.

Reviewed-by: Miao Xie <miaox@cn.fujitsu.com>

> ---
>  fs/btrfs/free-space-cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
> index e530096..73577f4 100644
> --- a/fs/btrfs/free-space-cache.c
> +++ b/fs/btrfs/free-space-cache.c
> @@ -213,7 +213,7 @@ int btrfs_check_trunc_cache_free_space(struct btrfs_root *root,
>  	else
>  		ret = 0;
>  	spin_unlock(&rsv->lock);
> -	return 0;
> +	return ret;
>  }
>  
>  int btrfs_truncate_free_space_cache(struct btrfs_root *root,
> 
> 


      reply	other threads:[~2013-05-22  1:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21  2:39 [PATCH -next] Btrfs: return error code in btrfs_check_trunc_cache_free_space() Wei Yongjun
2013-05-22  1:35 ` Miao Xie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519C20F7.1090709@cn.fujitsu.com \
    --to=miaox@cn.fujitsu.com \
    --cc=chris.mason@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=weiyj.lk@gmail.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.