All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Ott <alan@signal11.us>
To: Alan Ott <alan@signal11.us>
Cc: david@hauweele.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-zigbee-devel@lists.sourceforge.net
Subject: Re: [PATCH beta 1] 0/3] Fix race conditions in mrf24j40 interrupts
Date: Tue, 21 May 2013 22:03:59 -0400	[thread overview]
Message-ID: <519C278F.5030809@signal11.us> (raw)
In-Reply-To: <1369188080-8904-1-git-send-email-alan@signal11.us>

On 05/21/2013 10:01 PM, Alan Ott wrote:
> David Hauweele noticed that the mrf24j40 would hang arbitrarily after some
> period of heavy traffic.  Two race conditions were discovered, and the
> driver was changed to use threaded interrupts, since the enable/disable of
> interrupts in the driver has recently been a lighning rod whenever issues
> arise related to interrupts (costing engineering time), and since threaded
> interrupts are the right way to do it.
>
> Alan Ott (3):
>   mrf24j40: Move INIT_COMPLETION() to before packet transmission
>   mrf24j40: Use threaded IRQ handler
>   mrf24j40: Use level-triggered interrupts
>
>  drivers/net/ieee802154/mrf24j40.c | 31 +++++++++----------------------
>  1 file changed, 9 insertions(+), 22 deletions(-)

I forgot to add, I ran ping -f both ways all afternoon (6.5 hours), and
it seems solid.


  parent reply	other threads:[~2013-05-22  2:04 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-09 15:19 [PATCH 1/2] mrf24j40: Avoid transmission while receiving a frame David Hauweele
2013-05-09 15:19 ` David Hauweele
2013-05-09 15:19 ` [PATCH 2/2] mrf24j40: Keep the interrupt line enabled David Hauweele
2013-05-14  3:55   ` [Linux-zigbee-devel] " Alan Ott
2013-05-14  3:55     ` Alan Ott
2013-05-16 21:34     ` [Linux-zigbee-devel] " David Hauweele
2013-05-19 23:04       ` Alan Ott
2013-05-21 16:17         ` David Hauweele
2013-05-21 18:22           ` Alan Ott
2013-05-21 18:22             ` Alan Ott
2013-05-14  3:22 ` [Linux-zigbee-devel] [PATCH 1/2] mrf24j40: Avoid transmission while receiving a frame Alan Ott
     [not found]   ` <5191ADE4.8040709-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
2013-05-16 17:45     ` David Hauweele
2013-05-20  0:05       ` [PATCH testing] mrf24j40: Move INIT_COMPLETION to before the packet is sent Alan Ott
2013-05-20  0:05         ` Alan Ott
2013-05-22  2:01       ` [PATCH beta 1] 0/3] Fix race conditions in mrf24j40 interrupts Alan Ott
2013-05-22  2:01         ` Alan Ott
2013-05-22  2:01         ` [PATCH beta 1] 1/3] mrf24j40: Move INIT_COMPLETION() to before packet transmission Alan Ott
2013-05-22  2:01           ` Alan Ott
2013-05-22  2:01         ` [PATCH beta 1] 2/3] mrf24j40: Use threaded IRQ handler Alan Ott
2013-05-22  2:01           ` Alan Ott
2013-05-22  2:01         ` [PATCH beta 1] 3/3] mrf24j40: Use level-triggered interrupts Alan Ott
2013-05-22  2:03         ` Alan Ott [this message]
2013-05-22 20:32           ` [PATCH beta 1] 0/3] Fix race conditions in mrf24j40 interrupts David Hauweele
2013-05-23  6:36             ` Alan Ott
2013-05-23  6:36               ` Alan Ott
2013-05-23 17:54               ` David Hauweele
2013-05-23 17:54                 ` David Hauweele
2013-05-23 19:33                 ` Alan Ott
2013-10-06  3:52         ` [PATCH v1 " Alan Ott
2013-10-06  3:52           ` Alan Ott
2013-10-06  3:52           ` [PATCH v1 1/3] mrf24j40: Move INIT_COMPLETION() to before packet transmission Alan Ott
2013-10-06  3:52             ` Alan Ott
2013-10-06  3:52           ` [PATCH v1 2/3] mrf24j40: Use threaded IRQ handler Alan Ott
2013-10-06  3:52             ` Alan Ott
2013-10-06  3:52           ` [PATCH v1 3/3] mrf24j40: Use level-triggered interrupts Alan Ott
2013-10-06  3:52             ` Alan Ott
2013-10-08 19:32           ` [PATCH v1 0/3] Fix race conditions in mrf24j40 interrupts David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519C278F.5030809@signal11.us \
    --to=alan@signal11.us \
    --cc=david@hauweele.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-zigbee-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.