From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: [PATCH] drm/exynos: use drm_send_vblank_event() helper
Date: Wed, 22 May 2013 13:51:45 +0900
Message-ID: <519C4EE1.6020406@samsung.com>
References: <1349725849-22433-6-git-send-email-rob.clark@linaro.org>
	<1369195456-14697-1-git-send-email-inki.dae@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33])
	by gabe.freedesktop.org (Postfix) with ESMTP id 67A08E601A
	for <dri-devel@lists.freedesktop.org>;
	Tue, 21 May 2013 21:51:32 -0700 (PDT)
Received: from epcpsbgr2.samsung.com
	(u142.gpu120.samsung.co.kr [203.254.230.142])
	by mailout3.samsung.com (Oracle Communications Messaging Server
	7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011))
	with ESMTP id <0MN600675O5PZUH0@mailout3.samsung.com> for
	dri-devel@lists.freedesktop.org; Wed, 22 May 2013 13:51:31 +0900 (KST)
In-reply-to: <1369195456-14697-1-git-send-email-inki.dae@samsung.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Inki Dae <inki.dae@samsung.com>
Cc: Rob Clark <rob@ti.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi,

On 05/22/2013 01:04 PM, Inki Dae wrote:
> From: Rob Clark <rob@ti.com>
>
> Rebased.
>
> Signed-off-by: Rob Clark <rob@ti.com>
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>   drivers/gpu/drm/exynos/exynos_drm_crtc.c |   10 ++--------
>   1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
> index e8894bc..1e7825a 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
> @@ -398,7 +398,6 @@ void exynos_drm_crtc_finish_pageflip(struct drm_device *dev, int crtc)
>   {
>   	struct exynos_drm_private *dev_priv = dev->dev_private;
>   	struct drm_pending_vblank_event *e, *t;
> -	struct timeval now;
>   	unsigned long flags;
>   
>   	DRM_DEBUG_KMS("%s\n", __FILE__);
> @@ -411,14 +410,9 @@ void exynos_drm_crtc_finish_pageflip(struct drm_device *dev, int crtc)
>   		if (crtc != e->pipe)
>   			continue;
>   
> -		do_gettimeofday(&now);
> -		e->event.sequence = 0;
> -		e->event.tv_sec = now.tv_sec;
> -		e->event.tv_usec = now.tv_usec;
> -
> -		list_move_tail(&e->base.link, &e->base.file_priv->event_list);
> -		wake_up_interruptible(&e->base.file_priv->event_wait);
>   		drm_vblank_put(dev, crtc);
> +		list_del(&e->base.link);
> +		drm_send_vblank_event(dev, -1, e);

I think it's better to add above things before drm_vblank_put is called
in comparison with prior codes.

Thanks.