From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCHv4 16/39] thp, mm: locking tail page is a bug Date: Wed, 22 May 2013 07:53:55 -0700 Message-ID: <519CDC03.7070602@sr71.net> References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-17-git-send-email-kirill.shutemov@linux.intel.com> <519BD69E.5000207@sr71.net> <20130522141245.F047CE0090@blue.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: "Kirill A. Shutemov" Return-path: In-Reply-To: <20130522141245.F047CE0090@blue.fi.intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 05/22/2013 07:12 AM, Kirill A. Shutemov wrote: > Dave Hansen wrote: >> On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: >>> From: "Kirill A. Shutemov" >>> >>> Locking head page means locking entire compound page. >>> If we try to lock tail page, something went wrong. >> >> Have you actually triggered this in your development? > > Yes, on early prototypes. I'd mention this in the description, and think about how necessary this is with your _current_ code. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756311Ab3EVOx6 (ORCPT ); Wed, 22 May 2013 10:53:58 -0400 Received: from www.sr71.net ([198.145.64.142]:52427 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755026Ab3EVOx5 (ORCPT ); Wed, 22 May 2013 10:53:57 -0400 Message-ID: <519CDC03.7070602@sr71.net> Date: Wed, 22 May 2013 07:53:55 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 16/39] thp, mm: locking tail page is a bug References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-17-git-send-email-kirill.shutemov@linux.intel.com> <519BD69E.5000207@sr71.net> <20130522141245.F047CE0090@blue.fi.intel.com> In-Reply-To: <20130522141245.F047CE0090@blue.fi.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/22/2013 07:12 AM, Kirill A. Shutemov wrote: > Dave Hansen wrote: >> On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: >>> From: "Kirill A. Shutemov" >>> >>> Locking head page means locking entire compound page. >>> If we try to lock tail page, something went wrong. >> >> Have you actually triggered this in your development? > > Yes, on early prototypes. I'd mention this in the description, and think about how necessary this is with your _current_ code.