From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCHv4 26/39] ramfs: enable transparent huge page cache Date: Wed, 22 May 2013 07:55:44 -0700 Message-ID: <519CDC70.7010308@sr71.net> References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-27-git-send-email-kirill.shutemov@linux.intel.com> <519BF8A0.5000103@sr71.net> <20130522142236.315C7E0090@blue.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: "Kirill A. Shutemov" Return-path: In-Reply-To: <20130522142236.315C7E0090@blue.fi.intel.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 05/22/2013 07:22 AM, Kirill A. Shutemov wrote: > Dave Hansen wrote: >>> + /* >>> + * TODO: make ramfs pages movable >>> + */ >>> + mapping_set_gfp_mask(inode->i_mapping, >>> + GFP_TRANSHUGE & ~__GFP_MOVABLE); >> >> So, before these patches, ramfs was movable. Now, even on architectures >> or configurations that have no chance of using THP-pagecache, ramfs >> pages are no longer movable. Right? > > No, it wasn't movable. GFP_HIGHUSER is not GFP_HIGHUSER_MOVABLE (yeah, > names of gfp constants could be more consistent). > > ramfs should be fixed to use movable pages, but it's outside the scope of the > patchset. > > See more details: http://lkml.org/lkml/2013/4/2/720 Please make sure this is clear from the patch description. Personally, I wouldn't be adding TODO's to the code that I'm not planning to go fix, lest I would get tagged with _doing_ it. :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756452Ab3EVOzs (ORCPT ); Wed, 22 May 2013 10:55:48 -0400 Received: from www.sr71.net ([198.145.64.142]:52469 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756389Ab3EVOzr (ORCPT ); Wed, 22 May 2013 10:55:47 -0400 Message-ID: <519CDC70.7010308@sr71.net> Date: Wed, 22 May 2013 07:55:44 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 26/39] ramfs: enable transparent huge page cache References: <1368321816-17719-1-git-send-email-kirill.shutemov@linux.intel.com> <1368321816-17719-27-git-send-email-kirill.shutemov@linux.intel.com> <519BF8A0.5000103@sr71.net> <20130522142236.315C7E0090@blue.fi.intel.com> In-Reply-To: <20130522142236.315C7E0090@blue.fi.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/22/2013 07:22 AM, Kirill A. Shutemov wrote: > Dave Hansen wrote: >>> + /* >>> + * TODO: make ramfs pages movable >>> + */ >>> + mapping_set_gfp_mask(inode->i_mapping, >>> + GFP_TRANSHUGE & ~__GFP_MOVABLE); >> >> So, before these patches, ramfs was movable. Now, even on architectures >> or configurations that have no chance of using THP-pagecache, ramfs >> pages are no longer movable. Right? > > No, it wasn't movable. GFP_HIGHUSER is not GFP_HIGHUSER_MOVABLE (yeah, > names of gfp constants could be more consistent). > > ramfs should be fixed to use movable pages, but it's outside the scope of the > patchset. > > See more details: http://lkml.org/lkml/2013/4/2/720 Please make sure this is clear from the patch description. Personally, I wouldn't be adding TODO's to the code that I'm not planning to go fix, lest I would get tagged with _doing_ it. :)