Re: What's cooking in git.git (May 2013, #05; Mon, 20)

[Michael J Gruber <git@drmicha.warpmail.net>]

Junio C Hamano venit, vidit, dixit 22.05.2013 18:36:
> Michael J Gruber <git@drmicha.warpmail.net> writes:
> 
>>> * mg/more-textconv (2013-05-10) 7 commits
>>>  - grep: honor --textconv for the case rev:path
>>>  - grep: allow to use textconv filters
>>>  - t7008: demonstrate behavior of grep with textconv
>>>  - cat-file: do not die on --textconv without textconv filters
>>>  - show: honor --textconv for blobs
>>>  - diff_opt: track whether flags have been set explicitly
>>>  - t4030: demonstrate behavior of show with textconv
>>>
>>>  I think this is ready for 'next'; not that it matters during the
>>>  prerelease feature freeze.
>>
>> Oh, I'm sorry, I thought we were still in discussions about the default
>> mechanism (config or attributes) and the implementation (tacking context
>> onto each object)? Therefore, I didn't hurry to polish and follow up
>> over my vacation. I'm not sure I had smoothed out all minor things
>> (honor/obey and such) when the object struct size issue came up. I'll
>> check today or tomorrow. (Freeze, yes, but we don't want too many next
>> rewrites, and one is coming soon...)
> 
> I thought this was fine as-is, but we can kick it back to 'pu' and
> replace it with a reroll after 1.8.3 if that is necessary.

Didn't you have concerns about storing the context in the object struct?
I can't quite judge how much of an issue this can be for fsck and such.
I don't want to increase the memory footprint unnecessarily, of course.

Other than that, the mechanism was still up for discussion (separate
"show" attribute or a config) given that the default behavior for
showing blobs is not to change.

Michael