From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 11/17 v2] ARM: shmobile: bockw: add MMCIF support
Date: Thu, 23 May 2013 13:01:47 +0000 [thread overview]
Message-ID: <519E133B.8020400@cogentembedded.com> (raw)
In-Reply-To: <87wqqq2xh6.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 23.05.2013 7:20, Kuninori Morimoto wrote:
> Signed-off-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
[...]
> diff --git a/arch/arm/mach-shmobile/board-bockw.c b/arch/arm/mach-shmobile/board-bockw.c
> index 769069e..2f51e8b 100644
> --- a/arch/arm/mach-shmobile/board-bockw.c
> +++ b/arch/arm/mach-shmobile/board-bockw.c
[...]
> @@ -100,10 +117,24 @@ static struct spi_board_info spi_board_info[] __initdata = {
> },
> };
>
> +/* MMC */
> +static struct sh_mmcif_plat_data sh_mmcif_plat = {
I keep telling you that platform data and platform device resources
should be annotated with __initdata if you're using
platfrom_device_register_*() functions as they are copied to the heap
memory in this case...
> + .sup_pclk = 0,
> + .ocr = MMC_VDD_165_195 | MMC_VDD_32_33 | MMC_VDD_33_34,
> + .caps = MMC_CAP_4_BIT_DATA |
> + MMC_CAP_8_BIT_DATA |
> + MMC_CAP_NEEDS_POLL,
> +};
> +
WBR, Sergei
prev parent reply other threads:[~2013-05-23 13:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 3:20 [PATCH 11/17 v2] ARM: shmobile: bockw: add MMCIF support Kuninori Morimoto
2013-05-23 13:01 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519E133B.8020400@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.