From: Nicolas Schichan <nschichan@freebox.fr>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
Brian Austin <brian.austin@cirrus.com>,
Georgi Vlaev <joe@nucleusys.com>
Subject: Re: [PATCH 1/4] cs42l52: use same init values for MASTERA_VOL/MASTERB_VOL.
Date: Thu, 23 May 2013 15:17:24 +0200 [thread overview]
Message-ID: <519E16E4.1030604@freebox.fr> (raw)
In-Reply-To: <20130522183425.GW1627@sirena.org.uk>
On 05/22/2013 08:34 PM, Mark Brown wrote:
> On Wed, May 22, 2013 at 07:19:24PM +0200, Nicolas Schichan wrote:
>>
>> Signed-off-by: Nicolas Schichan <nschichan@freebox.fr>
>
> Why?
>
>> - { CS42L52_MASTERB_VOL, 0x00 }, /* r21 Master B Volume */
>> + { CS42L52_MASTERB_VOL, 0x88 }, /* r21 Master B Volume */
>
> Note that the register defaults need to reflect the default value
> for the registers.
I was not aware of that, The solution would be then to fix MASTERB_VOL default
value to 0x00 instead to 0x88. Shall I just send an updated version of the
patch or the whole serie ?
Regards,
--
Nicolas Schichan
Freebox SAS
next prev parent reply other threads:[~2013-05-23 13:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 17:19 [PATCH 0/4] CS42L52 fixes Nicolas Schichan
2013-05-22 17:19 ` [PATCH 1/4] cs42l52: use same init values for MASTERA_VOL/MASTERB_VOL Nicolas Schichan
2013-05-22 18:34 ` Mark Brown
2013-05-22 18:42 ` Austin, Brian
2013-05-23 13:17 ` Nicolas Schichan [this message]
2013-05-23 13:58 ` Mark Brown
2013-05-22 17:19 ` [PATCH 2/4] cs42l52: microphone bias is controlled by IFACE_CTL2 register Nicolas Schichan
2013-05-22 18:38 ` Mark Brown
2013-05-23 12:58 ` Nicolas Schichan
2013-05-23 13:25 ` Lars-Peter Clausen
2013-05-23 13:58 ` Mark Brown
2013-05-22 17:19 ` [PATCH 3/4] cs42l52: fix bogus shifts in "Speaker Volume" and "PCM Mixer Volume" controls Nicolas Schichan
2013-05-22 18:39 ` Mark Brown
2013-05-22 17:19 ` [PATCH 4/4] cs42l52: fix master playback mute mask Nicolas Schichan
2013-05-22 18:39 ` Mark Brown
2013-05-22 17:36 ` [PATCH 0/4] CS42L52 fixes Austin, Brian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519E16E4.1030604@freebox.fr \
--to=nschichan@freebox.fr \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=joe@nucleusys.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.