From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "B, Ravi" <ravibabu@ti.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Balbi, Felipe" <balbi@ti.com>
Subject: Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue
Date: Thu, 23 May 2013 22:21:34 +0400 [thread overview]
Message-ID: <519E5E2E.4070104@cogentembedded.com> (raw)
In-Reply-To: <6C6B28D4DC342643927BEAFCE8707BF63EAE3E31@DBDE04.ent.ti.com>
Hello.
On 05/23/2013 09:07 PM, B, Ravi wrote:
>>> removed unused nop xceiv (un_)register API's from all musb
>>> platform drivers
>> Since when are they unused?
> Please refer to commit id 662dca54 : usb: otg: support for multiple transceivers by a single controller.
> Usb_get_phy() is used to get the of phy used by controller, phy bindings are done through DT.
Why are you sure that all these platforms support DT (in all
configurations)?
It seems to me that you're simply breaking the patched glue layers with
this patch.
I'll let Felipe decide the fate of this patch though...
>
>>> Signed-off-by: Ravi Babu <ravibabu@ti.com>
> --
> Ravi B
WBR, Sergei
next prev parent reply other threads:[~2013-05-23 18:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 6:01 [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform Ravi Babu
2013-05-23 6:01 ` [PATCH v1 1/9] usb: musb: dsps: enable dual instance support for am33xx platform Ravi Babu
2013-05-23 6:01 ` [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue Ravi Babu
2013-05-23 14:22 ` Sergei Shtylyov
2013-05-23 17:07 ` B, Ravi
2013-05-23 18:21 ` Sergei Shtylyov [this message]
2013-05-24 5:34 ` B, Ravi
2013-05-24 14:41 ` Sergei Shtylyov
2013-05-23 6:01 ` [PATCH v1 3/9] arch: arm: omap3: remove unused usb_nop_xceive register API's Ravi Babu
2013-05-23 6:01 ` [PATCH v1 4/9] usb: phy: nop: removing unused usb_nop_xceiv_(un_)register API Ravi Babu
2013-05-23 6:01 ` [PATCH v1 5/9] usb: phy: dsps: adding usbphy driver for am33xx platform Ravi Babu
2013-05-23 6:01 ` [PATCH v1 6/9] usb: musb: dsps: use usb-phy driver API for phy power on/off Ravi Babu
2013-05-23 6:01 ` [PATCH v1 7/9] usb: musb: dsps: use get-usb-phy by phandle for multi instance Ravi Babu
2013-05-23 14:25 ` Sergei Shtylyov
2013-05-23 17:09 ` B, Ravi
2013-05-23 6:01 ` [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx Ravi Babu
2013-05-23 14:27 ` Sergei Shtylyov
2013-05-23 17:13 ` B, Ravi
2013-05-23 18:18 ` Sergei Shtylyov
2013-05-24 5:34 ` B, Ravi
2013-06-01 14:39 ` Sergei Shtylyov
2013-05-23 6:01 ` [PATCH v1 9/9] usb: musb: dsp: remove the usb-phy control acess from platform glue Ravi Babu
2013-05-28 17:39 ` [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform Felipe Balbi
2013-05-29 3:46 ` B, Ravi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519E5E2E.4070104@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ravibabu@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.