All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MMC: DWMMC: Fix FIFO_DEPTH calculation
Date: Fri, 24 May 2013 12:42:53 +0900	[thread overview]
Message-ID: <519EE1BD.6050202@samsung.com> (raw)
In-Reply-To: <1369314900-16412-1-git-send-email-rajeshwari.s@samsung.com>

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

On 05/23/2013 10:15 PM, Rajeshwari Shinde wrote:
> Current DWMMC driver used to give FIFO underrun/overrun error every 3rd time
> for mmc rescan command.
> In current code FIFO_DEPTH is getting calculated after reading the FIFOTH
> register and extracting the RX_WMARK bits from it i.e (RX_WMARK = FIFO_DEPTH/2 -1).
> Instead of storing the correct value, we were recalculating the FIFO_DEPT each
> time which is not correct.
> 
> Signed-off-by: Hatim Ali <hatim.rv@samsung.com>
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
>  drivers/mmc/dw_mmc.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index 4070d4e..be590a4 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -332,11 +332,13 @@ static int dwmci_init(struct mmc *mmc)
>  	dwmci_writel(host, DWMCI_BMOD, 1);
>  
>  	fifo_size = dwmci_readl(host, DWMCI_FIFOTH);
> -	if (host->fifoth_val)
> +	if (host->fifoth_val) {
>  		fifoth_val = host->fifoth_val;
> -	else
> +	} else {
>  		fifoth_val = MSIZE(0x2) | RX_WMARK(fifo_size/2 -1) |
>  			TX_WMARK(fifo_size/2);
> +		host->fifoth_val = fifoth_val;
> +	}
>  	dwmci_writel(host, DWMCI_FIFOTH, fifoth_val);
>  
>  	dwmci_writel(host, DWMCI_CLKENA, 0);
> 

      parent reply	other threads:[~2013-05-24  3:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-23 13:15 [U-Boot] [PATCH] MMC: DWMMC: Fix FIFO_DEPTH calculation Rajeshwari Shinde
2013-05-23 17:01 ` Alim Akhtar
2013-05-23 18:27 ` Jagan Teki
2013-05-24  1:42   ` Jaehoon Chung
2013-05-24  5:01     ` Jagan Teki
2013-05-24  6:15       ` Rajeshwari Birje
2013-05-24  6:46         ` Jaehoon Chung
2013-05-24  8:14           ` Jagan Teki
2013-05-24  3:42 ` Jaehoon Chung [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519EE1BD.6050202@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.