Re: [PATCH 0/4] ARM/early-printk: Improve reusability and add Calxeda support

[Julien Grall <julien.grall@linaro.org>]

On 05/24/2013 11:42 AM, Andre Przywara wrote:

> The current early-printk support for ARM is rather hard-coded, making
> it hard to add machines or tweak settings.
> This series slightly moves some code to gather UART settings in
> xen/arch/arm/Rules.mk instead of the actual .c files. Also it allows
> two different machines with different settings to share the same
> driver, which the last patch exploits to add support the Calxeda
> Midway hardware.
> 
> This haven't been extensively tested, but I looked at the generated
> assembly and did some quick checks on Versatile Express.


Thanks for this patch series, the UART code is now more generic :).

I tried all these patches on the fast model and the arndale board. I
didn't see any specific issue.

Cheers,

Julien

> 
> Signed-off-by: Andre Przywara <andre.przywara@calxeda.com>
> 
> Andre Przywara (4):
>   arm/early-printk: calculate baud rate divisor from user provided
>     value
>   arm/early-printk: allow skipping of UART init
>   arm/early-printk: move UART base address to Rules.mk
>   arm/early-printk: add Calxeda Midway UART support
> 
>  xen/arch/arm/Rules.mk                   | 13 +++++++++++++
>  xen/arch/arm/arm32/debug-exynos4210.inc |  6 ++----
>  xen/arch/arm/arm32/debug-pl011.inc      |  6 ++----
>  xen/arch/arm/arm32/head.S               |  2 ++
>  xen/arch/arm/arm64/debug-pl011.inc      |  6 ++----
>  xen/arch/arm/arm64/head.S               |  2 ++
>  6 files changed, 23 insertions(+), 12 deletions(-)
>