From: Eric Blake <eblake@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Amos Kong <akong@redhat.com>,
qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information
Date: Fri, 24 May 2013 07:23:11 -0600 [thread overview]
Message-ID: <519F69BF.7000005@redhat.com> (raw)
In-Reply-To: <20130524090834.41dd9108@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On 05/24/2013 07:08 AM, Luiz Capitulino wrote:
> This sounds like premature optimization to me, but I wonder if instead
> of cluttering commands with arguments to do the filtering we could add
> some standard way of doing this in the QAPI.
Maybe we could make QAPI support generic filtering for all query-*
commands. But there's still a cost with making all query-* commands
malloc the space for an entire list only to then have a QAPI layer on
top of it do filtering before handing back the single element over the
wire, compared to passing the filtering down to the query-*
implementation to do the filtering in place.
>
> It was you who suggested a filter command?
No, Stefan suggested it on v1:
https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03102.html
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-05-24 13:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 9:07 [Qemu-devel] [PATCH v3 0/2] mac programming over macvtap Amos Kong
2013-05-23 9:07 ` [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event Amos Kong
2013-05-23 10:24 ` Michael S. Tsirkin
2013-05-23 14:28 ` Luiz Capitulino
2013-05-23 14:43 ` Michael S. Tsirkin
2013-05-23 14:52 ` Eric Blake
2013-05-23 14:57 ` Michael S. Tsirkin
2013-05-23 15:33 ` Luiz Capitulino
2013-05-24 3:20 ` Amos Kong
2013-05-23 12:01 ` Eric Blake
2013-06-26 6:54 ` Markus Armbruster
2013-06-26 13:53 ` Luiz Capitulino
2013-05-23 9:08 ` [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information Amos Kong
2013-05-23 10:23 ` Michael S. Tsirkin
2013-05-24 4:53 ` Amos Kong
2013-05-23 12:14 ` Eric Blake
2013-05-24 3:03 ` Amos Kong
2013-06-26 7:14 ` Markus Armbruster
2013-05-23 16:03 ` Luiz Capitulino
2013-05-24 3:08 ` Amos Kong
2013-05-24 12:23 ` Luiz Capitulino
2013-05-24 12:55 ` Eric Blake
2013-05-24 13:08 ` Luiz Capitulino
2013-05-24 13:23 ` Eric Blake [this message]
2013-06-26 9:35 ` Markus Armbruster
2013-05-24 15:20 ` Markus Armbruster
2013-05-24 16:12 ` Michael S. Tsirkin
2013-05-24 18:05 ` Eric Blake
2013-05-24 20:00 ` Luiz Capitulino
2013-05-26 7:38 ` Michael S. Tsirkin
2013-05-27 8:36 ` Stefan Hajnoczi
2013-06-26 9:54 ` Markus Armbruster
2013-06-26 12:00 ` Markus Armbruster
2013-06-26 14:02 ` Luiz Capitulino
2013-06-26 14:15 ` Markus Armbruster
2013-06-28 14:04 ` Eric Blake
2013-06-28 17:27 ` Markus Armbruster
2013-07-01 3:24 ` Amos Kong
2013-07-02 6:33 ` Amos Kong
2013-07-02 9:05 ` Markus Armbruster
2013-07-02 10:40 ` Amos Kong
2013-07-02 13:27 ` Markus Armbruster
2013-07-04 3:31 ` Amos Kong
2013-07-04 6:28 ` Markus Armbruster
2013-07-11 14:05 ` Amos Kong
2013-07-12 6:32 ` Markus Armbruster
2013-07-12 7:07 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519F69BF.7000005@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.