From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 06/17 v2] ARM: shmobile: r8a7778: add I2C support
Date: Fri, 24 May 2013 14:10:34 +0000 [thread overview]
Message-ID: <519F74DA.8010607@cogentembedded.com> (raw)
In-Reply-To: <874ndu4c4n.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 24-05-2013 8:39, Kuninori Morimoto wrote:
>>> +void __init r8a7778_add_i2c_device(int id)
>>> +{
>>> + BUG_ON(id < 0 || id > 3);
>>> +
>>> + platform_device_register_simple(
>>> + "i2c-rcar", id,
>>> + i2c_resources + (2 * id), 2);
>> I've already told you () is superfluous.
> I can prevent misreading.
I don't think anybody familiar with arithmetic operator priorities
(i.e. having graduated from a primary school) can misread this.
> Best regards
> ---
> Kuninori Morimoto
WBR, Sergei
prev parent reply other threads:[~2013-05-24 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 3:18 [PATCH 06/17 v2] ARM: shmobile: r8a7778: add I2C support Kuninori Morimoto
2013-05-23 12:47 ` Sergei Shtylyov
2013-05-23 12:56 ` Sergei Shtylyov
2013-05-24 4:39 ` Kuninori Morimoto
2013-05-24 14:10 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519F74DA.8010607@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.