From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgAZ8-0007um-SR for qemu-devel@nongnu.org; Sat, 25 May 2013 05:15:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgAZ5-0000nj-Ep for qemu-devel@nongnu.org; Sat, 25 May 2013 05:15:06 -0400 Message-ID: <51A08113.6010903@msgid.tls.msk.ru> Date: Sat, 25 May 2013 13:14:59 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <20130522223817.GB14845@rox.home.comstyle.com> <519E3091.2060402@msgid.tls.msk.ru> <20130524184737.GA9642@rox.home.comstyle.com> In-Reply-To: <20130524184737.GA9642@rox.home.comstyle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brad Smith Cc: qemu-stable@nongnu.org, qemu-devel 24.05.2013 22:47, Brad Smith wrote: >>> +++ b/include/qemu-common.h >>> #elif defined CONFIG_BSD >>> +# include > Kinda late nit picking about it now. It's not. And it's not nitpicking really, we're carrying a ton of unnecessary #includes which slows down compilation significantly. The whole this piece of #include twist was to get declaration of openpty() or equivalent. You just stiffed an unrelated #include into this piece which was okay to remove completely. I already removed it from several other .c files where it went from vl.c originally, which used to have chardev code which is now in another file. What was the original issue? Where exactly it was failing? I mean, where's the _proper_ place to fix it? Speaking of "too late" -- it is definitely not late to fix another bug. Thanks, /mjt