From: Laxman Dewangan <ldewangan@nvidia.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
"cw00.choi@samsung.com" <cw00.choi@samsung.com>,
"balbi@ti.com" <balbi@ti.com>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"rob@landley.net" <rob@landley.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"george.cherian@ti.com" <george.cherian@ti.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>
Subject: Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver
Date: Sat, 25 May 2013 22:40:44 +0530 [thread overview]
Message-ID: <51A0F094.9010009@nvidia.com> (raw)
In-Reply-To: <1369405896-30246-3-git-send-email-kishon@ti.com>
Hi Graeme/Kishon,
On Friday 24 May 2013 08:01 PM, Kishon Vijay Abraham I wrote:
> From: Graeme Gregory <gg@slimlogic.co.uk>
>
> This is the driver for the USB comparator built into the palmas chip. It
> handles the various USB OTG events that can be generated by cable
> insertion/removal.
I have following feedback on this driver to use this on Tegra platform:
1. Can we have very simple driver for detecting VBUS and ID and just
generate notification. No VBUS control logic or lots of USB related
configurations?
2. We will need the VBUS control as optional if it is require for TI
platform. Currently it is mandatory and hence it is not suite in our
context.
3. There is VBUS control (enabled/disable) in VBUS detection also. When
palma detect the VBUS then why actually it need to enable VBUS as VBUS
is already supplied by HOST? It may be only need when palma detect the
ID pin and maybe want to enable VBUS but again VBUS control
(enable/disable) should be part of USB driver, out of extcon driver.
next prev parent reply other threads:[~2013-05-25 17:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 14:31 [PATCH 0/3] palmas usb driver Kishon Vijay Abraham I
2013-05-24 14:31 ` Kishon Vijay Abraham I
2013-05-24 14:31 ` [PATCH 1/3] drivers: regulator: palmas: add an API to set/clear the switch bit on SMPS10 Kishon Vijay Abraham I
2013-05-24 14:31 ` Kishon Vijay Abraham I
[not found] ` <1369405896-30246-2-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-05-24 15:09 ` Sergei Shtylyov
2013-05-24 15:09 ` Sergei Shtylyov
2013-05-25 17:00 ` Laxman Dewangan
2013-05-24 14:31 ` [PATCH v5 2/3] extcon: Palmas Extcon Driver Kishon Vijay Abraham I
2013-05-24 14:31 ` Kishon Vijay Abraham I
2013-05-25 17:10 ` Laxman Dewangan [this message]
2013-05-27 5:34 ` Chanwoo Choi
[not found] ` <51A2F07F.8070009-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-05-27 5:54 ` Kishon Vijay Abraham I
2013-05-27 5:54 ` Kishon Vijay Abraham I
2013-05-27 6:08 ` Chanwoo Choi
2013-05-27 6:22 ` Laxman Dewangan
[not found] ` <51A2FB88.9000303-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-27 6:31 ` Kishon Vijay Abraham I
2013-05-27 6:31 ` Kishon Vijay Abraham I
2013-05-27 6:36 ` Laxman Dewangan
[not found] ` <51A2FEE9.1060905-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-27 6:41 ` Kishon Vijay Abraham I
2013-05-27 6:41 ` Kishon Vijay Abraham I
2013-05-27 6:56 ` Laxman Dewangan
[not found] ` <51A3038E.3030405-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-05-27 9:24 ` Kishon Vijay Abraham I
2013-05-27 9:24 ` Kishon Vijay Abraham I
2013-05-24 14:31 ` [PATCH 3/3] usb: dwc3: use extcon fwrk to receive connect/disconnect notification Kishon Vijay Abraham I
2013-05-24 14:31 ` Kishon Vijay Abraham I
2013-05-27 5:38 ` Chanwoo Choi
2013-05-30 23:45 ` Chanwoo Choi
2013-05-27 13:33 ` [PATCH v6] extcon: Palmas Extcon Driver Kishon Vijay Abraham I
2013-05-27 13:33 ` Kishon Vijay Abraham I
2013-05-28 2:51 ` Chanwoo Choi
[not found] ` <1369405896-30246-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-05-27 13:35 ` [PATCH v2] usb: dwc3: use extcon fwrk to receive connect/disconnect notification Kishon Vijay Abraham I
2013-05-27 13:35 ` Kishon Vijay Abraham I
[not found] ` <1369661740-15966-1-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-05-28 2:24 ` Chanwoo Choi
2013-05-28 2:24 ` Chanwoo Choi
[not found] ` <51A41559.20808-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-05-28 5:27 ` Kishon Vijay Abraham I
2013-05-28 5:27 ` Kishon Vijay Abraham I
2013-05-28 17:35 ` [PATCH 0/3] palmas usb driver Felipe Balbi
2013-05-28 17:35 ` Felipe Balbi
[not found] ` <20130528173554.GD15794-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-05-29 6:06 ` Kishon Vijay Abraham I
2013-05-29 6:06 ` Kishon Vijay Abraham I
2013-05-29 17:38 ` Felipe Balbi
2013-05-29 17:38 ` Felipe Balbi
[not found] ` <20130529173851.GC21290-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2013-05-30 2:17 ` Chanwoo Choi
2013-05-30 2:44 ` Chanwoo Choi
2013-05-30 2:46 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A0F094.9010009@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=george.cherian@ti.com \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.