[Qemu-devel] [PATCH] Remove OSS support for OpenBSD

[Qemu-devel] [PATCH] Remove OSS support for OpenBSD

[Brad Smith]

Remove the OSS support for OpenBSD. The OSS API has not been usable
for quite some time.

Signed-off-by: Brad Smith <brad@comstyle.com>


diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index 00be9c9..007c641 100644
--- a/audio/ossaudio.c
+++ b/audio/ossaudio.c
@@ -25,11 +25,7 @@
 #include <sys/mman.h>
 #include <sys/types.h>
 #include <sys/ioctl.h>
-#ifdef __OpenBSD__
-#include <soundcard.h>
-#else
 #include <sys/soundcard.h>
-#endif
 #include "qemu-common.h"
 #include "qemu/main-loop.h"
 #include "qemu/host-utils.h"
diff --git a/configure b/configure
index 5ae7e4a..eb74510 100755
--- a/configure
+++ b/configure
@@ -468,9 +468,8 @@ NetBSD)
 OpenBSD)
   bsd="yes"
   make="${MAKE-gmake}"
-  audio_drv_list="oss"
-  audio_possible_drivers="oss sdl esd"
-  oss_lib="-lossaudio"
+  audio_drv_list="sdl"
+  audio_possible_drivers="sdl esd"
 ;;
 Darwin)
   bsd="yes"

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD

[Laszlo Ersek]

On 05/25/13 01:01, Brad Smith wrote:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
> 
> Signed-off-by: Brad Smith <brad@comstyle.com>
> 
> 
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 00be9c9..007c641 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -25,11 +25,7 @@
>  #include <sys/mman.h>
>  #include <sys/types.h>
>  #include <sys/ioctl.h>
> -#ifdef __OpenBSD__
> -#include <soundcard.h>
> -#else
>  #include <sys/soundcard.h>
> -#endif
>  #include "qemu-common.h"
>  #include "qemu/main-loop.h"
>  #include "qemu/host-utils.h"
> diff --git a/configure b/configure
> index 5ae7e4a..eb74510 100755
> --- a/configure
> +++ b/configure
> @@ -468,9 +468,8 @@ NetBSD)
>  OpenBSD)
>    bsd="yes"
>    make="${MAKE-gmake}"
> -  audio_drv_list="oss"
> -  audio_possible_drivers="oss sdl esd"
> -  oss_lib="-lossaudio"
> +  audio_drv_list="sdl"
> +  audio_possible_drivers="sdl esd"
>  ;;
>  Darwin)
>    bsd="yes"
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Re: [Qemu-trivial] [Qemu-devel] [PATCH] Remove OSS support for OpenBSD

[Andreas Färber]

Am 25.05.2013 01:01, schrieb Brad Smith:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
> 
> Signed-off-by: Brad Smith <brad@comstyle.com>

Reviewed-by: Andreas Färber <afaerber@suse.de>

CC'ing qemu-trivial.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD

[Andreas Färber]

Am 25.05.2013 01:01, schrieb Brad Smith:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
> 
> Signed-off-by: Brad Smith <brad@comstyle.com>

Reviewed-by: Andreas Färber <afaerber@suse.de>

CC'ing qemu-trivial.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH] Remove OSS support for OpenBSD

[Blue Swirl]

On Fri, May 24, 2013 at 11:01 PM, Brad Smith <brad@comstyle.com> wrote:
> Remove the OSS support for OpenBSD. The OSS API has not been usable
> for quite some time.
>
> Signed-off-by: Brad Smith <brad@comstyle.com>

Thanks, applied.

>
>
> diff --git a/audio/ossaudio.c b/audio/ossaudio.c
> index 00be9c9..007c641 100644
> --- a/audio/ossaudio.c
> +++ b/audio/ossaudio.c
> @@ -25,11 +25,7 @@
>  #include <sys/mman.h>
>  #include <sys/types.h>
>  #include <sys/ioctl.h>
> -#ifdef __OpenBSD__
> -#include <soundcard.h>
> -#else
>  #include <sys/soundcard.h>
> -#endif
>  #include "qemu-common.h"
>  #include "qemu/main-loop.h"
>  #include "qemu/host-utils.h"
> diff --git a/configure b/configure
> index 5ae7e4a..eb74510 100755
> --- a/configure
> +++ b/configure
> @@ -468,9 +468,8 @@ NetBSD)
>  OpenBSD)
>    bsd="yes"
>    make="${MAKE-gmake}"
> -  audio_drv_list="oss"
> -  audio_possible_drivers="oss sdl esd"
> -  oss_lib="-lossaudio"
> +  audio_drv_list="sdl"
> +  audio_possible_drivers="sdl esd"
>  ;;
>  Darwin)
>    bsd="yes"
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>