From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH 18/34] drm/i915: Drop dev from pte_encode Date: Sat, 25 May 2013 13:14:43 -0700 Message-ID: <51A11BB3.60708@whitecape.org> References: <1369510028-3343-1-git-send-email-ben@bwidawsk.net> <1369510028-3343-19-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from homiemail-a62.g.dreamhost.com (caiajhbdcagg.dreamhost.com [208.97.132.66]) by gabe.freedesktop.org (Postfix) with ESMTP id 982EFE5C14 for ; Sat, 25 May 2013 13:13:14 -0700 (PDT) In-Reply-To: <1369510028-3343-19-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On 05/25/2013 12:26 PM, Ben Widawsky wrote: > The original pte_encode function needed the dev argument so we could do > platform specific handling via IS_GENX, etc. With the merging of a pte > encoding function there should never been a need to quirk away gen > specific details. > > The patch doesn't do much but makes the upcoming reworks in gtt/ppgtt/mm > slightly (albeit, ever so) easier. > > CC: Kenneth Graunke > Signed-off-by: Ben Widawsky Seems reasonable to me - just swap out pte_encode based on gen, rather than looking at gen in the function. Reviewed-by: Kenneth Graunke