From: Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
gururaja.hebbar-l0cyMroinI0@public.gmane.org,
benoit.cousson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [net-next PATCH v2 1/6] net: cpsw: enhance pinctrl support
Date: Sun, 26 May 2013 12:49:14 +0530 [thread overview]
Message-ID: <51A1B772.4070201@ti.com> (raw)
In-Reply-To: <20130525.234248.683332656832128763.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On 5/26/2013 12:12 PM, David Miller wrote:
> From: Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>
> Date: Thu, 23 May 2013 18:00:23 +0530
>
>> From: Hebbar Gururaja <gururaja.hebbar-l0cyMroinI0@public.gmane.org>
>>
>> Amend cpsw controller to optionally take a pin control handle and set
>> the state of the pins to:
>>
>> - "default" on boot, resume
>> - "sleep" on suspend()
>>
>> This should make it possible to optimize energy usage for the pins
>> for the suspend/resume cycle.
>>
>> If any of the above pin states are missing in dt, a warning message
>> about the missing state is displayed.
>> If certain pin-states are not available, to remove this warning message
>> pass respective state name with null phandler.
>>
>> Signed-off-by: Hebbar Gururaja <gururaja.hebbar-l0cyMroinI0@public.gmane.org>
>> Signed-off-by: Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org>
> This still needs some work:
>
>> + /*
>> + * Since we continue even when pinctrl node is not found,
>> + * Invalidate pins as not available. This is to make sure that
>> + * IS_ERR(pins_xxx) results in failure when used.
>> + */
> The second, third, fourth, and fifth lines are not tabbed correctly. They
> should all be two TABs and a SPACE.
>
> Secondly, comments in the networking are to be formatted:
>
> /* Like
> * this.
> */
Will fix this and will resubmit the next version today.
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-05-26 7:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 12:30 [net-next PATCH v2 0/6] Adding pinctrl PM support for CPSW and MDIO Mugunthan V N
2013-05-23 12:30 ` Mugunthan V N
2013-05-23 12:30 ` [net-next PATCH v2 1/6] net: cpsw: enhance pinctrl support Mugunthan V N
2013-05-23 12:30 ` Mugunthan V N
[not found] ` <1369312228-3308-2-git-send-email-mugunthanvnm-l0cyMroinI0@public.gmane.org>
2013-05-26 6:42 ` David Miller
[not found] ` <20130525.234248.683332656832128763.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-05-26 7:19 ` Mugunthan V N [this message]
2013-05-23 12:30 ` [net-next PATCH v2 2/6] net: davinci_mdio: " Mugunthan V N
2013-05-23 12:30 ` Mugunthan V N
2013-05-23 12:30 ` [net-next PATCH v2 3/6] ARM: dts: AM33XX: Add pinmux configuration for CPSW to beaglebone Mugunthan V N
2013-05-23 12:30 ` Mugunthan V N
2013-05-23 12:30 ` [net-next PATCH v2 4/6] ARM: dts: AM33XX: Add CPSW phy_id device tree data to am335x-evmsk Mugunthan V N
2013-05-23 12:30 ` Mugunthan V N
2013-05-23 12:30 ` [net-next PATCH v2 5/6] ARM: dts: AM33XX: Add pinmux configuration for CPSW to EVMsk Mugunthan V N
2013-05-23 12:30 ` Mugunthan V N
2013-05-23 12:30 ` [net-next PATCH v2 6/6] ARM: dts: AM33XX: Add pinmux configuration for CPSW to am335x EVM Mugunthan V N
2013-05-23 12:30 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A1B772.4070201@ti.com \
--to=mugunthanvnm-l0cymroini0@public.gmane.org \
--cc=benoit.cousson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=gururaja.hebbar-l0cyMroinI0@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.