From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgcLL-00024R-6W for qemu-devel@nongnu.org; Sun, 26 May 2013 10:54:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UgcLC-0005Fz-09 for qemu-devel@nongnu.org; Sun, 26 May 2013 10:54:43 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53981 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UgcLB-0005Ft-Pi for qemu-devel@nongnu.org; Sun, 26 May 2013 10:54:33 -0400 Message-ID: <51A22222.2030409@suse.de> Date: Sun, 26 May 2013 16:54:26 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <519FDF35.207@redhat.com> In-Reply-To: <519FDF35.207@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] FPU x86 instructions error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Clemens Kolbitsch Cc: "qemu-devel@nongnu.org" , Richard Henderson Hi, Am 24.05.2013 23:44, schrieb Paolo Bonzini: > Il 24/05/2013 23:39, Clemens Kolbitsch ha scritto: >> we recently had an issue with running a program using FPU instructions >> to obtain the current EIP (basically a weird way of "call 0; pop eax") >> that was not working on QEMU (with TCG). >> >> Looking at the problem, we found this patch to be useful/fixing the is= sue: >> >> https://launchpadlibrarian.net/140457932/patch-qemu-1.5.0-fpip.diff >> >> Looking through the DEVEL archives, I found this patch >> >> http://lists.nongnu.org/archive/html/qemu-devel/2011-06/msg01206.html >> >> that adds the FPU flags to the environment, but is only using them for= KVM. >> >> I was wondering - since the above patch is rather old, you have >> probably come across it before - if there was a reason for not >> including it in QEMU (I checked in git:master and it's not applied). >> If there isn't, maybe it'd be worth re-considering :) >=20 > For the TCG patch, there is no Signed-off-by and using a helper is not > necessary. Clemens, generally we can't just take another person's patch and apply it - that's what we need the Signed-off-by for. Your post is the only Google hit for that link and no hits for fpip in my archive - you'll need to contact the author to obtain her Sob and properly submit it to qemu-devel - or post a patch yourself that is not based on that one. http://wiki.qemu.org/Contribute/SubmitAPatch > For the KVM patch, it simply fell through the cracks, I believe. It didn't: http://git.qemu.org/?p=3Dqemu.git;a=3Dcommit;h=3D42cc8fa620cbc73e349e96d8= 4cf46469e828ec34 (I was about to suggest placing the non-TCG fields into X86CPU. :)) Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg