From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Stefan Beller <stefanbeller@googlemail.com>
Cc: David Barr <david.barr@cordelta.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] fast-import: Remove redundant assignment of 'oe' to itself.
Date: Sun, 26 May 2013 22:08:23 +0200 [thread overview]
Message-ID: <51A26BB7.3060702@gmail.com> (raw)
In-Reply-To: <1369598719-10798-1-git-send-email-stefanbeller@googlemail.com>
On 05/26/2013 10:05 PM, Stefan Beller wrote:
> Reported by cppcheck.
>
> Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
> ---
> fast-import.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fast-import.c b/fast-import.c
> index 5f539d7..0142e3a 100644
> --- a/fast-import.c
> +++ b/fast-import.c
> @@ -2914,7 +2914,7 @@ static void cat_blob(struct object_entry *oe, unsigned char sha1[20])
> static void parse_cat_blob(void)
> {
> const char *p;
> - struct object_entry *oe = oe;
>
This was done on purpose, to avoid spurious warnings with (at least)
some versions of GCC.
> + struct object_entry *oe;
> unsigned char sha1[20];
>
> /* cat-blob SP <object> LF */
Regards,
Stefano
next prev parent reply other threads:[~2013-05-26 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 20:05 [PATCH] fast-import: Remove redundant assignment of 'oe' to itself Stefan Beller
2013-05-26 20:08 ` Stefano Lattarini [this message]
2013-05-26 20:14 ` Stefan Beller
2013-05-26 20:17 ` Stefano Lattarini
2013-05-26 20:23 ` Stefan Beller
2013-05-28 8:22 ` Joachim Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A26BB7.3060702@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=david.barr@cordelta.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.