From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver Date: Mon, 27 May 2013 12:01:46 +0530 Message-ID: <51A2FDD2.10309@ti.com> References: <1369405896-30246-1-git-send-email-kishon@ti.com> <1369405896-30246-3-git-send-email-kishon@ti.com> <51A2F07F.8070009@samsung.com> <51A2F512.2090907@ti.com> <51A2F84D.9030605@samsung.com> <51A2FB88.9000303@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <51A2FB88.9000303-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Laxman Dewangan Cc: "george.cherian-l0cyMroinI0@public.gmane.org" , "sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , "linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "balbi-l0cyMroinI0@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Chanwoo Choi , "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , "gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org" List-Id: linux-omap@vger.kernel.org Hi, On Monday 27 May 2013 11:52 AM, Laxman Dewangan wrote: > On Monday 27 May 2013 11:38 AM, Chanwoo Choi wrote: >> On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote: >>>> Hi Kishon, >>>> >>>> I have some comment about this patch >>>> and upload modified patch to following repository (extcon-for-palmas). >>>> - >>>> http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/= ?h=3Dextcon-for-palmas&id=3Df2b7cb80699cbe1a5fd6c97ef2c600915f8d7f2c >>>> >>>> >>>> This patchset include patch related to other module >>>> ,so I need your opinion to apply this patchset to git repository. >>> yeah.. Still there is some confusion with palmas_set_switch_smps10(). >>> I think we can remove it for now and add it separately later. By this >>> at least we can have device mode fully functional in OMAP5. What do >>> you think? >>> >> I agree your opinion. >> >> But, I propose some fixes about palmas_set_switch_smps10(). >> I dont' prefer to call global function in exton-palmas.c from >> palmas-regulator.c. >> So, Why don't you use regulator consumer instead of global function? >> You can register specific regulator for enabling or disabling >> SMPS10_SWITCH_EN >> and then control SMPS10_SWITCH_EN bit through regulator framework in >> extcon-palmas.c >> without calling global function. > > Along with this, I also like to make the VBUS regulator control to be > optional here. Currently it is mandatory. But dint you just tell on my v4 of this patch that you don=92t require this. http://www.spinics.net/lists/linux-doc/msg10638.html Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756508Ab3E0Gce (ORCPT ); Mon, 27 May 2013 02:32:34 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:36099 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753616Ab3E0Gcc (ORCPT ); Mon, 27 May 2013 02:32:32 -0400 Message-ID: <51A2FDD2.10309@ti.com> Date: Mon, 27 May 2013 12:01:46 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Laxman Dewangan CC: Chanwoo Choi , "myungjoo.ham@samsung.com" , "balbi@ti.com" , "gg@slimlogic.co.uk" , "lgirdwood@gmail.com" , "broonie@kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" , "grant.likely@linaro.org" , "rob.herring@calxeda.com" , "rob@landley.net" , "gregkh@linuxfoundation.org" , "george.cherian@ti.com" , "sameo@linux.intel.com" Subject: Re: [PATCH v5 2/3] extcon: Palmas Extcon Driver References: <1369405896-30246-1-git-send-email-kishon@ti.com> <1369405896-30246-3-git-send-email-kishon@ti.com> <51A2F07F.8070009@samsung.com> <51A2F512.2090907@ti.com> <51A2F84D.9030605@samsung.com> <51A2FB88.9000303@nvidia.com> In-Reply-To: <51A2FB88.9000303@nvidia.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday 27 May 2013 11:52 AM, Laxman Dewangan wrote: > On Monday 27 May 2013 11:38 AM, Chanwoo Choi wrote: >> On 05/27/2013 02:54 PM, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Monday 27 May 2013 11:04 AM, Chanwoo Choi wrote: >>>> Hi Kishon, >>>> >>>> I have some comment about this patch >>>> and upload modified patch to following repository (extcon-for-palmas). >>>> - >>>> http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-for-palmas&id=f2b7cb80699cbe1a5fd6c97ef2c600915f8d7f2c >>>> >>>> >>>> This patchset include patch related to other module >>>> ,so I need your opinion to apply this patchset to git repository. >>> yeah.. Still there is some confusion with palmas_set_switch_smps10(). >>> I think we can remove it for now and add it separately later. By this >>> at least we can have device mode fully functional in OMAP5. What do >>> you think? >>> >> I agree your opinion. >> >> But, I propose some fixes about palmas_set_switch_smps10(). >> I dont' prefer to call global function in exton-palmas.c from >> palmas-regulator.c. >> So, Why don't you use regulator consumer instead of global function? >> You can register specific regulator for enabling or disabling >> SMPS10_SWITCH_EN >> and then control SMPS10_SWITCH_EN bit through regulator framework in >> extcon-palmas.c >> without calling global function. > > Along with this, I also like to make the VBUS regulator control to be > optional here. Currently it is mandatory. But dint you just tell on my v4 of this patch that you don’t require this. http://www.spinics.net/lists/linux-doc/msg10638.html Thanks Kishon