From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: agraf@suse.de, David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI
Date: Mon, 27 May 2013 09:03:04 +0200 [thread overview]
Message-ID: <51A30528.9020708@redhat.com> (raw)
In-Reply-To: <51A301AC.8070101@ozlabs.ru>
Il 27/05/2013 08:48, Alexey Kardashevskiy ha scritto:
>> >
>> > This is only true when the rerror and werror options have the values
>> > "ignore" or "report". See virtio-scsi for an example of how to save the
>> > requests using the save_request and load_request callbacks in SCSIBusInfo.
>
> Sigh.
?
> How do you test that requests are saved/restored correctly? What does
> happen to requests which were already sent to the real hardware (real block
> device, etc) but have not completed at the moment of the end of migration?
They aren't saved, there is a bdrv_drain_all() in the migration code.
This is only used for rerror=stop or werror=stop. To test it you can
use blkdebug (also a bit underdocumented) or hack block/raw-posix.c with
code that makes it fail the 100th write or something like that. Start
the VM and migrate it while paused to a QEMU that doesn't have the hack.
Paolo
next prev parent reply other threads:[~2013-05-27 7:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 1:38 [Qemu-devel] [0/8] pseries: savevm / migration support David Gibson
2013-05-03 1:38 ` [Qemu-devel] [PATCH 1/8] savevm: Implement VMS_DIVIDE flag David Gibson
2013-05-03 1:38 ` [Qemu-devel] [PATCH 2/8] target-ppc: Convert ppc cpu savevm to VMStateDescription David Gibson
2013-05-03 11:29 ` Andreas Färber
2013-05-03 14:26 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-03 1:38 ` [Qemu-devel] [PATCH 3/8] pseries: savevm support for XICS interrupt controller David Gibson
2013-05-03 1:38 ` [Qemu-devel] [PATCH 4/8] pseries: savevm support for VIO devices David Gibson
2013-05-03 1:38 ` [Qemu-devel] [PATCH 5/8] pseries: savevm support for PAPR VIO logical lan David Gibson
2013-05-03 1:38 ` [Qemu-devel] [PATCH 6/8] pseries: savevm support for PAPR TCE tables David Gibson
2013-05-03 1:38 ` [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI David Gibson
2013-05-06 7:37 ` Paolo Bonzini
2013-05-07 3:07 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-27 6:48 ` [Qemu-devel] " Alexey Kardashevskiy
2013-05-27 7:03 ` Paolo Bonzini [this message]
2013-05-31 5:58 ` Alexey Kardashevskiy
2013-05-31 8:18 ` Paolo Bonzini
2013-05-31 10:12 ` Alexey Kardashevskiy
2013-05-31 10:26 ` Paolo Bonzini
2013-05-31 10:33 ` Alexey Kardashevskiy
2013-05-31 10:34 ` Paolo Bonzini
2013-05-31 10:07 ` Benjamin Herrenschmidt
2013-05-31 10:25 ` Alexey Kardashevskiy
2013-05-31 10:41 ` Paolo Bonzini
2013-06-01 0:01 ` Benjamin Herrenschmidt
2013-06-03 6:21 ` Paolo Bonzini
2013-06-03 5:46 ` Alexey Kardashevskiy
2013-06-03 6:23 ` Paolo Bonzini
2013-06-03 8:07 ` Benjamin Herrenschmidt
2013-06-03 9:37 ` Alexey Kardashevskiy
2013-06-03 9:41 ` Paolo Bonzini
2013-05-03 1:38 ` [Qemu-devel] [PATCH 8/8] pseries: savevm support for pseries machine David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A30528.9020708@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.