All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tiejun.chen" <tiejun.chen@windriver.com>
To: Jain Priyanka-B32167 <B32167@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc/32bit, PREEMPT:Load TI_FLAGS to check NEED_RESCHED
Date: Mon, 27 May 2013 15:18:42 +0800	[thread overview]
Message-ID: <51A308D2.6040101@windriver.com> (raw)
In-Reply-To: <AC83832D6324604BB08FAE5A33553F190B3B7A4C@039-SN2MPN1-012.039d.mgd.msft.net>

On 05/27/2013 02:55 PM, Jain Priyanka-B32167 wrote:
>
> If we go some more lines up in the same file, the code is
>
> resume_kernel:
>          /* check current_thread_info, _TIF_EMULATE_STACK_STORE */
>          CURRENT_THREAD_INFO(r9, r1)
>          lwz     r8,TI_FLAGS(r9)
>          andis.  r8,r8,_TIF_EMULATE_STACK_STORE@h

Okay, but could you fix this directly like:

diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
index e514de5..4498467 100644
--- a/arch/powerpc/kernel/entry_32.S
+++ b/arch/powerpc/kernel/entry_32.S
@@ -851,7 +851,7 @@ resume_kernel:
         /* check current_thread_info, _TIF_EMULATE_STACK_STORE */
         CURRENT_THREAD_INFO(r9, r1)
         lwz     r8,TI_FLAGS(r9)
-       andis.  r8,r8,_TIF_EMULATE_STACK_STORE@h
+       andis.  r0,r8,_TIF_EMULATE_STACK_STORE@h
         beq+    1f

         addi    r8,r1,INT_FRAME_SIZE    /* Get the kprobed function entry */

Tiejun

  reply	other threads:[~2013-05-27  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27  6:27 [PATCH] powerpc/32bit,PREEMPT:Load TI_FLAGS to check NEED_RESCHED Priyanka Jain
2013-05-27  6:45 ` [PATCH] powerpc/32bit, PREEMPT:Load " tiejun.chen
2013-05-27  6:55   ` [PATCH] powerpc/32bit,PREEMPT:Load " Jain Priyanka-B32167
2013-05-27  7:18     ` tiejun.chen [this message]
2013-05-27  7:21       ` Jain Priyanka-B32167
2013-05-27  7:12 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A308D2.6040101@windriver.com \
    --to=tiejun.chen@windriver.com \
    --cc=B07421@freescale.com \
    --cc=B32167@freescale.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.