All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, mikey@neuling.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc, perf: Ignore separate BHRB privilege state filter request
Date: Mon, 27 May 2013 15:32:07 +0530	[thread overview]
Message-ID: <51A32F1F.5020109@linux.vnet.ibm.com> (raw)
In-Reply-To: <519C88D9.30009@linux.vnet.ibm.com>

On 05/22/2013 02:29 PM, Anshuman Khandual wrote:
>>
>> Your description from patch 0 should be here.
> Does it sound better ?
> 
>>
>>> -	if ((br_privilege != 7) && (br_privilege != 0))
>>> -		return -1;
>>> +
>>> +	if (br_privilege)
>>> +		pr_info("BHRB privilege state filter request %llx ignored\n",
>>> +								br_privilege);
>>
>> Don't do that. Ignoring the br_privilege is either the right thing to do
>> in which case we do it and print nothing,
> 
> 
> I thought the informational print would at least make the user aware
> of the fact that the separate filter request for BHRB went ignored.
> Can we add this some where in the documentation ?

So, what we decide here ? We will just ignore any separate BHRB
privilege state filter request without printing any informational
event or warning ?

  reply	other threads:[~2013-05-27 10:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22  5:47 [PATCH 0/2] Improvement and fixes for BHRB Anshuman Khandual
2013-05-22  5:47 ` Anshuman Khandual
2013-05-22  5:47 ` [PATCH 1/2] powerpc, perf: Ignore separate BHRB privilege state filter request Anshuman Khandual
2013-05-22  5:47   ` Anshuman Khandual
2013-05-22  7:14   ` Michael Ellerman
2013-05-22  7:14     ` Michael Ellerman
2013-05-22  8:59     ` Anshuman Khandual
2013-05-22  8:59       ` Anshuman Khandual
2013-05-27 10:02       ` Anshuman Khandual [this message]
2013-05-27 23:30         ` Michael Neuling
2013-05-27 23:30           ` Michael Neuling
2013-05-22  5:47 ` [PATCH 2/2] powerpc, perf: BHRB filter configuration should follow the task Anshuman Khandual
2013-05-22  5:47   ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A32F1F.5020109@linux.vnet.ibm.com \
    --to=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.