From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2 v3] ARM: shmobile: r8a7778: rename device additional function for sh-eth
Date: Mon, 27 May 2013 10:27:16 +0000 [thread overview]
Message-ID: <51A33504.3050507@cogentembedded.com> (raw)
In-Reply-To: <87fvx98aj2.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 27-05-2013 5:41, Kuninori Morimoto wrote:
> Current r8a7778 is using r8a7778_add_ether_device().
> Here, this "ether" means "sh-eth".
It will be renamed in the future. Then what, another rename?
> Now, we use r8a7778_register_xxx() instead of r8a7778_add_xxx_device()
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
NAK. In the manual the device is called Ether and I perefer to stick
with this name. And all this rename is just pointless churn which Linus
and RMK will frown at.
WBR, Sergei
prev parent reply other threads:[~2013-05-27 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 1:41 [PATCH 1/2 v3] ARM: shmobile: r8a7778: rename device additional function for sh-eth Kuninori Morimoto
2013-05-27 10:27 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A33504.3050507@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.