All of lore.kernel.org
 help / color / mirror / Atom feed
From: Renaud Barbier <renaud.barbier@ge.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mtd: call mtd_erase with complete area if possible
Date: Mon, 27 May 2013 12:17:27 +0100	[thread overview]
Message-ID: <51A340C7.4050704@ge.com> (raw)
In-Reply-To: <1369643920-20604-1-git-send-email-s.hauer@pengutronix.de>

On 27/05/2013 09:38, Sascha Hauer wrote:
> If a device does not have bad blocks loop over the eraseblocks
> in the driver instead of the core. This allows the mtd_dataflash
> driver to erase blocks instead of pages to gain more speed during
> erasing. Also the mtd_dataflash driver modifies the erase_info
> struct which causes the outer loop in the core to never end.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>
> Renaud, you recently sent a patch to fix erase on non uniform
> flashes. This patch should fix this (by accident) aswell (or maybe
> it causes other problems ;). Could you please test this one?
>
> Thanks
>   Sascha


It does work.
If I define /dev/env0 to be 64KB i.e two sectors, then data in both 
sector has been erased.

barebox> / unprotect /dev/env0
barebox> / erase /dev/env0
mtd_op_erase = 65536
cfi_erase: erase 0x00000000 (size 65536)
intel_flash_erase_one:sect = 0
intel_flash_erase_one:sect = 1





_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2013-05-27 11:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-27  8:38 [PATCH] mtd: call mtd_erase with complete area if possible Sascha Hauer
2013-05-27 11:17 ` Renaud Barbier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A340C7.4050704@ge.com \
    --to=renaud.barbier@ge.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.