From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Bandan Das" <bsd@redhat.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled
Date: Mon, 27 May 2013 15:14:25 +0200 [thread overview]
Message-ID: <51A35C31.9050902@redhat.com> (raw)
In-Reply-To: <20130527130712.GB2580@otherpad.lan.raisama.net>
Il 27/05/2013 15:07, Eduardo Habkost ha scritto:
>> Changing TCG to KVM should not change hardware
>> > if you use "-cpu ...,enforce", so it is right that it fails when
>> > starting with KVM.
>> >
> Changing between KVM and TCG _does_ change hardware, today (with or
> without check/enforce). All CPU models on TCG have features not
> supported by TCG automatically removed. See the "if (!kvm_enabled())"
> block at x86_cpu_realizefn().
Perhaps (for "-cpu ...,enforce" or check) that's the real bug we have to
fix?
Paolo
> (That's why I argue that we need separate classes/names for TCG and KVM
> modes. Otherwise our predefined models get less useful as they will
> require low-level feature-bit fiddling on the libvirt side to make them
> work as expected.)
>
next prev parent reply other threads:[~2013-05-27 13:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 1:13 [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled Bandan Das
2013-05-25 1:21 ` Bandan Das
2013-05-25 6:25 ` Paolo Bonzini
2013-05-27 12:09 ` Eduardo Habkost
2013-05-27 12:21 ` Paolo Bonzini
2013-05-27 13:07 ` Eduardo Habkost
2013-05-27 13:14 ` Paolo Bonzini [this message]
2013-05-27 13:32 ` Eduardo Habkost
2013-05-28 16:34 ` Bandan Das
2013-05-28 16:46 ` Paolo Bonzini
2013-05-28 16:48 ` Andreas Färber
2013-05-29 14:31 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A35C31.9050902@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=bsd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.