From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Uh4G2-0003ii-Je for mharc-qemu-trivial@gnu.org; Mon, 27 May 2013 16:43:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh4Fw-0003af-J4 for qemu-trivial@nongnu.org; Mon, 27 May 2013 16:43:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uh4Ft-0000fp-Jd for qemu-trivial@nongnu.org; Mon, 27 May 2013 16:43:00 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:59992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh4Fk-0000Re-4s; Mon, 27 May 2013 16:42:48 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id D643541D10; Tue, 28 May 2013 00:42:44 +0400 (MSK) Message-ID: <51A3C543.9020608@msgid.tls.msk.ru> Date: Tue, 28 May 2013 00:42:43 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/17.0 Icedove/17.0 MIME-Version: 1.0 To: li guang References: <1369363654-7063-1-git-send-email-lig.fnst@cn.fujitsu.com> <51A08422.7030207@msgid.tls.msk.ru> <51A093F6.4070202@suse.de> <51A09581.6030105@msgid.tls.msk.ru> <1369618853.19028.20.camel@liguang.fnst.cn.fujitsu.com> In-Reply-To: <1369618853.19028.20.camel@liguang.fnst.cn.fujitsu.com> X-Enigmail-Version: 1.6a1pre OpenPGP: id=804465C5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: Anthony Liguori , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Gerd Hoffmann , Paolo Bonzini , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 May 2013 20:43:05 -0000 27.05.2013 05:40, li guang wrote: [] >>> NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes >>> no sense as-is (just look at the stderr output to see what I mean) and >>> it pretends that I suggested that! >> >> Actually I did just that, rebuild with DEBUG_DEBUGCON and looked >> at the output, -- because I didn't know how it works. And you're >> right, it's not a good change ;) But your email come before I was >> able to reply. Unqueued. > > Hi, Michael Hello. Please excuse me for the long(ish) delay, I was out of the city when you sent this email and when you pinged me on IRC. > do you queued patch 1-3? > if so, I will only send one patch for comments from Andreas, > otherwise, I will refactor all patches. Yes I queued your patches 1-3 but not 4. It can be seen at http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next (I just rebased it again on top of current qemu/master, but your 3 patches are there). Should I replace these 3 with the next set? But as Gerd correctly say, maybe it's better to just get rid of these stuff completely, or maybe, just maybe, replace it with tracepoints. Anyway, I think the 3 queued-up patches are okay. Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uh4Fq-0003Ti-Ii for qemu-devel@nongnu.org; Mon, 27 May 2013 16:42:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uh4Fk-0000WU-DH for qemu-devel@nongnu.org; Mon, 27 May 2013 16:42:54 -0400 Message-ID: <51A3C543.9020608@msgid.tls.msk.ru> Date: Tue, 28 May 2013 00:42:43 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1369363654-7063-1-git-send-email-lig.fnst@cn.fujitsu.com> <51A08422.7030207@msgid.tls.msk.ru> <51A093F6.4070202@suse.de> <51A09581.6030105@msgid.tls.msk.ru> <1369618853.19028.20.camel@liguang.fnst.cn.fujitsu.com> In-Reply-To: <1369618853.19028.20.camel@liguang.fnst.cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: li guang Cc: Anthony Liguori , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Gerd Hoffmann , Paolo Bonzini , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= 27.05.2013 05:40, li guang wrote: [] >>> NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes >>> no sense as-is (just look at the stderr output to see what I mean) and >>> it pretends that I suggested that! >> >> Actually I did just that, rebuild with DEBUG_DEBUGCON and looked >> at the output, -- because I didn't know how it works. And you're >> right, it's not a good change ;) But your email come before I was >> able to reply. Unqueued. > > Hi, Michael Hello. Please excuse me for the long(ish) delay, I was out of the city when you sent this email and when you pinged me on IRC. > do you queued patch 1-3? > if so, I will only send one patch for comments from Andreas, > otherwise, I will refactor all patches. Yes I queued your patches 1-3 but not 4. It can be seen at http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/trivial-patches-next (I just rebased it again on top of current qemu/master, but your 3 patches are there). Should I replace these 3 with the next set? But as Gerd correctly say, maybe it's better to just get rid of these stuff completely, or maybe, just maybe, replace it with tracepoints. Anyway, I think the 3 queued-up patches are okay. Thanks, /mjt